Skip to content

x test --stage 1 tests/rustdoc{,-ui} fails when download-rustc is enabled #110570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyn514 opened this issue Apr 20, 2023 · 3 comments
Closed

x test --stage 1 tests/rustdoc{,-ui} fails when download-rustc is enabled #110570

jyn514 opened this issue Apr 20, 2023 · 3 comments
Labels
A-download-rustc Area: The `rust.download-rustc` build option. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2023

I tried this code: ./configure --set download-rustc && x test --stage 1 rustdoc-ui

I expected to see this happen: All tests pass

Instead, this happened:

warning: `download-rustc` does nothing when building stage1 tools; consider using `--stage 2` instead
Building tool rustdoc (stage0 -> stage1)
    Finished release [optimized] target(s) in 0.07s
Check compiletest suite=rustdoc-ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 221 tests
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFiFFFFFFFFFFFFFFFFFFFFFFF  88/221
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF 176/221
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

test result: FAILED. 0 passed; 220 failed; 1 ignored; 0 measured; 0 filtered out; finished in 142.79ms

Some tests failed in compiletest suite=rustdoc-ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu

Meta

HEAD is 39c6804

I think this is pretty low priority, I don't know why anyone would need to run x test --stage 1 when download-rustc is enabled.

@jyn514 jyn514 added P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-download-rustc Area: The `rust.download-rustc` build option. labels Apr 20, 2023
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 6, 2023
@jieyouxu
Copy link
Member

pinging back #131744

@onur-ozkan
Copy link
Member

Thanks for the ping, adding it to the tracking issue.

@onur-ozkan
Copy link
Member

I just remembered I fixed this issue with with #126153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-download-rustc Area: The `rust.download-rustc` build option. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants