Skip to content

Automated handling of busted assembly tests #110751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
workingjubilee opened this issue Apr 24, 2023 · 4 comments
Open

Automated handling of busted assembly tests #110751

workingjubilee opened this issue Apr 24, 2023 · 4 comments
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@workingjubilee
Copy link
Member

There are assembly tests we know in advance are busted.

They

  • specify a --target in the compiletest headers
  • do not have only-{arch} in the compiletest headers
  • are neither #![no_core] or #![no_std], and do not -Zbuild-std
  • are testing assembly generation of the compiler, and especially including asm!

We could lint these automatically and probably should.

@workingjubilee workingjubilee added A-testsuite Area: The testsuite used to check the correctness of rustc A-inline-assembly Area: Inline assembly (`asm!(…)`) labels Apr 24, 2023
@Ezrashaw
Copy link
Contributor

are neither #![no_core] or #![no_std], and do not -Zbuild-std
are testing assembly generation of the compiler, and especially including asm!

Could you elaborate? I think that the test in my recent PR checks both of these boxes but is still useful.

As an aside, do you think this should be implemented in tidy or compiletest itself?

@workingjubilee
Copy link
Member Author

That entire list is a single logical constraint.

@workingjubilee
Copy link
Member Author

No idea on where this code could/should live, that feels like a vibes decision.

@thomcc
Copy link
Member

thomcc commented Apr 24, 2023

compiletest is used out of tree (sort of) so probably tidy is more appropriate for this kind of thing.

@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants