Skip to content

Return Option rather than fail on empty vectors. #11733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Jan 22, 2014 · 1 comment · Fixed by #11944
Closed

Return Option rather than fail on empty vectors. #11733

SimonSapin opened this issue Jan 22, 2014 · 1 comment · Fixed by #11944

Comments

@SimonSapin
Copy link
Contributor

#11129 changed the shift, pop and last methods of vectors to return an Option instead of failing on empty vectors. These methods should probably get the same change, to be consistent

  • shift_ref
  • pop_ref
  • mut_last
  • mut_shift_ref
  • mut_pop_ref
@nathanielherman
Copy link
Contributor

I'll try to fix this!

@nathanielherman nathanielherman mentioned this issue Jan 30, 2014
Merged
@bors bors closed this as completed in df044ea Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SimonSapin @nathanielherman