Skip to content

Rust offline windows installer missing clippy, source and rustfmt #123463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Matthew-Jenkins opened this issue Apr 4, 2024 · 2 comments
Closed
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Matthew-Jenkins
Copy link

Verification

* [x]  I searched for recent similar issues at https://github.com/rust-lang/rustup/issues?q=is%3Aissue+is%3Aopen%2Cclosed and found no duplicates.

* [x]  I am on the latest version of Rustup according to https://github.com/rust-lang/rustup/tags and am still able to reproduce my issue.

Problem

I work for a large enterprise so online installers won't work for me. I download the windows offline installer but it is missing cargo-clippy, rustfmt and the source. rust-analyzer can not process macros without the source.

Steps

1. Go to https://forge.rust-lang.org/infra/other-installation-methods.html#standalone and download any of the windows offline installers.

2. After installing check C:\Program Files\Rust???\ . bin will be missing cargo-clippy and rustfmt. lib/rustup/ will be missing src

3. rust-analyzer will give constant errors due to not being able to process macros. You won't be able to run the clippy linter, you won't be able to auto format to minimize diffs.

Possible Solution(s)

Add missing parts to windows offline installers.

Notes

No response

Rustup version

1.75 and 1.77 have been tested

Installed toolchains

x86_64-pc-windows-msvc

OS version

Windows 10
@Matthew-Jenkins Matthew-Jenkins added the C-bug Category: This is a bug. label Apr 4, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 4, 2024
@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 4, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 4, 2024

Thanks for the report! I believe this is a duplicate of #101993, so closing in favor of that.

@ehuss ehuss closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 4, 2024

As for rust-src, I don't think any of the installers include that because it is a common component across all platforms. That is currently tracked in #85460.

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants