Skip to content

Crater runs for 1.86 #137445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mark-Simulacrum opened this issue Feb 22, 2025 · 21 comments
Closed

Crater runs for 1.86 #137445

Mark-Simulacrum opened this issue Feb 22, 2025 · 21 comments
Labels
C-crater Category: Issue for tracking crater runs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Note: Please do not conduct triage on these runs without discussing how to do so with a release team member first. Thanks!

@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Feb 22, 2025
@Mark-Simulacrum Mark-Simulacrum added this to the 1.86.0 milestone Feb 22, 2025
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.86-1 start=1.85.0 end=beta-2025-02-18 mode=build-and-test cap-lints=warn p=1

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.86-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.86-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 22, 2025
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.86-rustdoc-1 start=1.85.0 end=beta-2025-02-18 mode=rustdoc cap-lints=warn p=1

@Mark-Simulacrum Mark-Simulacrum added C-crater Category: Issue for tracking crater runs and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 22, 2025
@craterbot
Copy link
Collaborator

👌 Experiment beta-1.86-rustdoc-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 22, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 22, 2025
@Urgau Urgau removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 22, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.86-rustdoc-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.86-1 is completed!
📊 6389 regressed and 139 fixed (587195 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 24, 2025
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.86-2 start=1.85.0 end=beta-2025-02-18 mode=build-and-test cap-lints=warn p=1 crates=https://crater-reports.s3.amazonaws.com/beta-1.86-1/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.86-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.86-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.86-rustdoc-1 is completed!
📊 3995 regressed and 90 fixed (587195 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 25, 2025
@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.86-2 is completed!
📊 6246 regressed and 13 fixed (10387 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.86-3 start=1.85.0 end=beta-2025-02-28 mode=build-and-test cap-lints=warn p=1 crates=https://crater-reports.s3.amazonaws.com/beta-1.86-2/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.86-3 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.86-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.86-3 is completed!
📊 6186 regressed and 2 fixed (6463 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 2, 2025
@Mark-Simulacrum
Copy link
Member Author

@Skgland
Copy link
Contributor

Skgland commented Mar 3, 2025

  • RustcDecodable/Encodable removal affects lots of crates (probably most of the regressions come from that)

It looks to me like most of the regressions (5957 out of 6186) are wasm-bindgen with the following error:

error: older versions of the wasm-bindgen crate are incompatible with current versions of Rust; please update to wasm-bindgen v0.2.88

@Mark-Simulacrum
Copy link
Member Author

Yeah, good point. That already has relnotes tracked in #135691 (comment).

@Skgland
Copy link
Contributor

Skgland commented Mar 11, 2025

Yeah, good point. That already has relnotes tracked in #135691 (comment).

The tracked release notes currently say to update to at least 0.2.89 while the error message in the crater run asks to update to 0.2.88. Does one have an of-by-one error or did the version change in between?

@Mark-Simulacrum
Copy link
Member Author

88 appears to be yanked, so I went with 89. I could see us backporting a trivial fix to the diagnostic, I don't have time to work on that myself though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-crater Category: Issue for tracking crater runs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants