Skip to content

Some htmldocck tests could be cleaned up #21740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomjakubowski opened this issue Jan 29, 2015 · 0 comments
Closed

Some htmldocck tests could be cleaned up #21740

tomjakubowski opened this issue Jan 29, 2015 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tomjakubowski
Copy link
Contributor

For example, the rustdoc-where tests originally used regexes as a kludge to avoid trying to match HTML tags, but with htmldocck they can now check against text nodes.

Something like:

// @matches foo/struct.Alpha.html '//pre' "Alpha.*where.*A:.*MyTrait"

can be greatly clarified like:

// @matches foo/struct.Alpha.html '//pre' "pub struct Alpha<A> where A: MyTrait"
@kmcallister kmcallister added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 30, 2015
@bors bors closed this as completed in 43b8503 Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmcallister @tomjakubowski