Skip to content

rustdoc broken hyperlinks for [src] of reexported macros (e.g. std::unimplemented!) #23928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rprichard opened this issue Apr 1, 2015 · 1 comment
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@rprichard
Copy link
Contributor

On this page, https://doc.rust-lang.org/std/macro.unimplemented!.html, the [src] hyperlink points to https://doc.rust-lang.org/src/std/%3Ccore%20macros%3E.html#1, which does not exist.

The same problem happens on https://doc.rust-lang.org/std/macro.format!.html, which points to https://doc.rust-lang.org/src/std/%3Ccore_collections%20macros%3E.html#1-2. The filename here is <core_collections macros>.html, which matches the name that collections is aliased to in libstd below.

I think the problem happens with macros that are reexported from another crate.

This seems to be a complete list of reexported macros in Rust's standard library:

src/libstd/lib.rs:

#[macro_use]
#[macro_reexport(assert, assert_eq, debug_assert, debug_assert_eq,
    unreachable, unimplemented, write, writeln)]
extern crate core;

#[macro_use]
#[macro_reexport(vec, format)]
extern crate collections as core_collections;
@steveklabnik steveklabnik added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) labels Apr 1, 2015
@rprichard
Copy link
Contributor Author

@steveklabnik Oh wait, this is obviously a duplicate of #23913, which you just opened.

I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants