Skip to content

Linkage regression in servo with 1.2 #27043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jul 14, 2015 · 3 comments
Closed

Linkage regression in servo with 1.2 #27043

brson opened this issue Jul 14, 2015 · 3 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jul 14, 2015

See servo/servo#6591 (comment)

After some tweaks to how rustc drives the linker Servo no longer links. We should decide whether this is intentional and acceptable.

@brson brson added A-tools regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 14, 2015
@brson
Copy link
Contributor Author

brson commented Jul 14, 2015

cc @pcwalton @larsbergstrom

@larsbergstrom
Copy link
Contributor

This is particularly painful for us because it disallows multiple references to the same library. We had to use those multiple references in order to force a deterministic link order on platforms where symbol availability is based on the order in which libraries are listed.

I assume that Rust and Cargo now provide enough control that we should be able to remove that usage pattern now, but this change had some pretty far-rippling effects for us, even to fix it on just OSX and just the case where we're producing a shared library.

@alexcrichton
Copy link
Member

I think Servo's now working after upgrading and otherwise I've transferred tags to #26869 (the PR in question)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants