Skip to content

Add an "inherits" key or similar to JSON target specs #32819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aatch opened this issue Apr 8, 2016 · 4 comments
Open

Add an "inherits" key or similar to JSON target specs #32819

Aatch opened this issue Apr 8, 2016 · 4 comments
Labels
A-target-specs Area: Compile-target specifications C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Aatch
Copy link
Contributor

Aatch commented Apr 8, 2016

Looking at #32818, most of the target spec used there is just copying the existing i686-pc-windows-msvc target settings. This seems a little unnecessary, especially if we add to the options in the spec. A key in the JSON that indicates an existing target to use as a base seems like it would be useful.

Potential names:

  • "inherits"
  • "extends"
  • "base"
@Mark-Simulacrum
Copy link
Member

Would this require an RFC? Or is this something that just needs to be implemented?

@Mark-Simulacrum
Copy link
Member

@eddyb I recall you mentioning that we wanted inheriting support (or had?); perhaps that's implemented today? I don't think so, but ... maybe?

@eddyb
Copy link
Member

eddyb commented May 15, 2017

No idea. cc @rust-lang/compiler

@Mark-Simulacrum Mark-Simulacrum added the A-target-specs Area: Compile-target specifications label Jun 22, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 25, 2017
@steveklabnik
Copy link
Member

Triage: no changes.

@cardoe cardoe mentioned this issue Aug 2, 2020
Open
@ids1024 ids1024 mentioned this issue Oct 9, 2020
Open
@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-target-specs Area: Compile-target specifications C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @eddyb @Aatch @Mark-Simulacrum @jieyouxu