Skip to content

Flash of dark theme in rustdoc #50063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ruuda opened this issue Apr 18, 2018 · 2 comments
Closed

Flash of dark theme in rustdoc #50063

ruuda opened this issue Apr 18, 2018 · 2 comments

Comments

@ruuda
Copy link
Contributor

ruuda commented Apr 18, 2018

Currently, for every page I load on https://doc.rust-lang.org/std, there is a “flash of dark theme” for almost a second, as you can see in this timeline:

flash-of-dark

Furthermore, the entire docs load very slowly, even with a primed cache. (You can also see fonts kicking in very late.) I suspect part of the reason is that all resources are served with cache-control: max-age=0, no-store, no-cache, must-revalidate, including fonts and style sheets. I don’t know if this is done on purpose because the docs are updated frequently? If so, using an etag would probably be a better solution.

@ruuda
Copy link
Contributor Author

ruuda commented Apr 18, 2018

I can only reproduce this in Chromium, not in Firefox.

@varkor
Copy link
Member

varkor commented Apr 18, 2018

This is a duplicate of #49648. The bug has been fixed, but the fix will unfortunately take a little time to get into the live version of the docs!

@varkor varkor closed this as completed Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants