Skip to content

Update to 1.26.1 fails on ARM due to missing docs artifact #51097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blackus2 opened this issue May 26, 2018 · 8 comments
Closed

Update to 1.26.1 fails on ARM due to missing docs artifact #51097

blackus2 opened this issue May 26, 2018 · 8 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@blackus2
Copy link

blackus2 commented May 26, 2018

I cannot update to rust version 1.26.1 (nor 1.26.0) on arm-unknown-linux-gnuabihf. Rustup fails with:

RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup update stable
info: syncing channel updates for 'stable-arm-unknown-linux-gnueabihf'
info: latest update on 2018-05-25, rust version 1.26.1 (827013a31 2018-05-25)
error: component 'rust-docs' for 'arm-unknown-linux-gnueabihf' is unavailable for download

My rustup is on the newest version:

$ rustup self update
info: checking for self-updates
$ rustup --version
rustup 1.11.0 (e751ff9f8 2018-02-13)

According to a post on reddit it seems to be working on armv7-unknown-linux-gnueabihf.

edit: CC @pietroalbini

@Mark-Simulacrum
Copy link
Member

Cc @alexcrichton

@Mark-Simulacrum
Copy link
Member

RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup install stable-arm-unknown-linux-gnueabihf works for me and makes no attempt to install rust-docs component. I'm not sure what the cause of the error you see could be, since I can't reproduce... is there a chance you could also paste output for RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup -v install stable-arm-unknown-linux-gnueabihf? It might be that you need to run rustup install stable instead of rustup update stable...

@pietroalbini pietroalbini added C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. labels May 26, 2018
@pietroalbini
Copy link
Member

Tested this locally, the bug only appears when running update instead of install on an existing toolchain. Steps to reproduce:

rustup toolchain install 1.24.0-arm-unknown-linux-gnueabihf
mv ~/.rustup/toolchains/{1.24.0,stable}-arm-unknown-linux-gnueabihf
mv ~/.rustup/update-hashes/{1.24.0,stable}-arm-unknown-linux-gnueabihf
RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup update stable-arm-unknown-linux-gnueabihf

@Mark-Simulacrum
Copy link
Member

I've added a note about using install instead of update to the blog post, hopefully that should be sufficient.

@pietroalbini
Copy link
Member

Can we get a rustup release that ignores a component if it's missing from the new manifest before releasing 1.26.1 though? I can try working on a PR tomorrow.

@blackus2
Copy link
Author

@Mark-Simulacrum: Sure thing. Even though it may no longer be interesting (due to the whole install vs update thing) here's the output you requested:

$ RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup -v install stable-arm-unknown-linux-gnueabihf
verbose: read metadata version: '12'
verbose: updating existing install for 'stable-arm-unknown-linux-gnueabihf'
verbose: toolchain directory: '/home/pi/.rustup/toolchains/stable-arm-unknown-linux-gnueabihf'
info: syncing channel updates for 'stable-arm-unknown-linux-gnueabihf'
verbose: creating temp file: /home/pi/.rustup/tmp/q2dx0efbqg186xqa_file
verbose: downloading file from: 'https://dev-static.rust-lang.org/dist/channel-rust-stable.toml.sha256'
verbose: downloading with curl
verbose: deleted temp file: /home/pi/.rustup/tmp/q2dx0efbqg186xqa_file
verbose: creating temp file: /home/pi/.rustup/tmp/13n69k_jkpqpbzvj_file.toml
verbose: downloading file from: 'https://dev-static.rust-lang.org/dist/channel-rust-stable.toml'
verbose: downloading with curl
verbose: checksum passed
verbose: deleted temp file: /home/pi/.rustup/tmp/13n69k_jkpqpbzvj_file.toml
info: latest update on 2018-05-25, rust version 1.26.1 (827013a31 2018-05-25)
error: component 'rust-docs' for 'arm-unknown-linux-gnueabihf' is unavailable for download

Ignoring certain components if they are missing seems like a valid option. As long as it is not strictly necessary (in this case docs) I think a warning instead of an error should be enough.

@pietroalbini
Copy link
Member

OK, the PR fixing rustup is merged, it would be nice to have a new rustup release out before 1.26.1.

@pietroalbini
Copy link
Member

This can be considered as fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants