Skip to content

master doens't build on Windows due to CR characters in rustc-guide #57479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steveklabnik opened this issue Jan 9, 2019 · 4 comments
Closed

master doens't build on Windows due to CR characters in rustc-guide #57479

steveklabnik opened this issue Jan 9, 2019 · 4 comments

Comments

@steveklabnik
Copy link
Member

tidy is failing with

tidy error: C:\Users\steve\src\rust\src\doc\rustc-guide\ci\install.sh:24: CR character

on both check_line_lengths.sh and install.sh on the rustc guide. I'm using MSVC.

Any thoughts here?
@steveklabnik steveklabnik mentioned this issue Jan 9, 2019
Closed
@retep998
Copy link
Member

retep998 commented Jan 9, 2019 •
edited
Loading

That should have been fixed by rust-lang/rustc-dev-guide#246 but since you say it fails on the current master, something must still be wrong.

@steveklabnik
Copy link
Member Author

Supposedly, the rustc repo was set to the commit after that PR landed, so that seems very strange...

@steveklabnik
Copy link
Member Author

I deleted the build directory and this seemed to fix it. I have no idea why, but let's trust CI and not me 😆

@petrochenkov
Copy link
Contributor

The submodule may need to be re-initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @retep998 @petrochenkov