Skip to content

rustdoc: std::collections::HashSet is not shown in search results since 1.50.0 #89872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camelid opened this issue Oct 14, 2021 · 4 comments
Closed

rustdoc: std::collections::HashSet is not shown in search results since 1.50.0 #89872

camelid opened this issue Oct 14, 2021 · 4 comments
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Oct 14, 2021

Interestingly, this goes both ways:

  • In 1.49.0, only std::collections::HashSet is shown (not std::collections::hash_set::HashSet, which is public and stable).
  • In 1.50.0, only std::collections::hash_set::HashSet is shown (not std::collections::HashSet).

So there seems to be a bug in both versions. Note that this is a re-exports bug, but not a cross-crate re-exports bug.

1.49.0

image

1.50.0

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Oct 14, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 14, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 14, 2021

In 1.50.0, only std::collections::hash_set::HashSet is shown (not std::collections::HashSet).

Is hash_set public? If so, I don't think this is actually a bug, libstd doesn't indicate in any way which definition should take precedence.

@camelid
Copy link
Member Author

camelid commented Oct 15, 2021

In 1.50.0, only std::collections::hash_set::HashSet is shown (not std::collections::HashSet).

Is hash_set public? If so, I don't think this is actually a bug, libstd doesn't indicate in any way which definition should take precedence.

It is public. But usually, rustdoc shows both definitions in the case of re-exports; they don't take precedence over each other.

@camelid camelid added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Nov 2, 2021
@euclio
Copy link
Contributor

euclio commented Dec 9, 2021

cc #86337

@jieyouxu
Copy link
Member

Seems to have been fixed (at least https://doc.rust-lang.org/std/collections/struct.HashSet.html?search=hashset shows both). Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@euclio @jyn514 @camelid @jieyouxu @rustbot