From 8d77c2eab8b74d6731c6811a1df54f444559cb04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Mi=C4=85sko?= Date: Thu, 28 Dec 2023 00:00:00 +0000 Subject: [PATCH] Don't validate / lint MIR before each pass To avoid redundant work and verbose output in case of failures. --- compiler/rustc_mir_transform/src/pass_manager.rs | 6 ------ tests/ui/mir/lint/storage-live.stderr | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/compiler/rustc_mir_transform/src/pass_manager.rs b/compiler/rustc_mir_transform/src/pass_manager.rs index 1da1c1920b249..82074f1960d25 100644 --- a/compiler/rustc_mir_transform/src/pass_manager.rs +++ b/compiler/rustc_mir_transform/src/pass_manager.rs @@ -129,12 +129,6 @@ fn run_passes_inner<'tcx>( if dump_enabled { dump_mir_for_pass(tcx, body, name, false); } - if validate { - validate_body(tcx, body, format!("before pass {name}")); - } - if lint { - lint_body(tcx, body, format!("before pass {name}")); - } if let Some(prof_arg) = &prof_arg { tcx.sess diff --git a/tests/ui/mir/lint/storage-live.stderr b/tests/ui/mir/lint/storage-live.stderr index 1037ddc88ef65..02156dd858db2 100644 --- a/tests/ui/mir/lint/storage-live.stderr +++ b/tests/ui/mir/lint/storage-live.stderr @@ -1,4 +1,4 @@ -error: internal compiler error: broken MIR in Item(DefId(0:8 ~ storage_live[HASH]::multiple_storage)) (before pass CheckPackedRef) at bb0[1]: +error: internal compiler error: broken MIR in Item(DefId(0:8 ~ storage_live[HASH]::multiple_storage)) (after pass CheckPackedRef) at bb0[1]: StorageLive(_1) which already has storage here --> $DIR/storage-live.rs:22:13 |