Port rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser#152296
Open
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
Open
Port rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser#152296jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser#152296jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred to constck cc @fee1-dead Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the CTFE machinery |
rustbot
added
A-attributes
jdonszelmann
changed the title
rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser
9 tasks
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This was referenced Feb 7, 2026
rust-bors
bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rust-nonnull-guaranteed
branch
from
8c3514e to
513a578
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
removed
the
S-waiting-on-bors
Contributor
Author
|
@bors r- |
jdonszelmann
force-pushed
the
port-rust-nonnull-guaranteed
branch
from
513a578 to
26ee8ee
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 9, 2026
…ranteed, r=jonathanbrouwer Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser r? @JonathanBrouwer another two of them :)
rust-bors
bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r- |
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rust-nonnull-guaranteed
branch
from
26ee8ee to
9fee1a2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rust-nonnull-guaranteed
branch
from
9fee1a2 to
86200bf
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This was referenced Feb 13, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
…uwer Rollup of 14 pull requests Successful merges: - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`) - #152469 (Remove unused features) - #152515 (Extract `DepKindVTable` constructors to their own module) - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers) - #152218 (Report unconstrained region in hidden types lazily) - #152356 (Improve the `inline_fluent!` macro) - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics) - #152407 (Add regression test for type_const with unit struct ctor under mGCA) - #152440 (Fix typos and grammar in compiler and build documentation) - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls) - #152554 (Remove `deprecated_safe` and its corresponding feature gate) - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2) - #152563 (Replace "bug" with "issue" in triagebot ping messages) - #152565 (fix missleading error for tuple ctor) Failed merges: - #152512 (core: Implement feature `float_exact_integer_constants`) - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
…uwer Rollup of 14 pull requests Successful merges: - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`) - #152469 (Remove unused features) - #152515 (Extract `DepKindVTable` constructors to their own module) - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers) - #152218 (Report unconstrained region in hidden types lazily) - #152356 (Improve the `inline_fluent!` macro) - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics) - #152407 (Add regression test for type_const with unit struct ctor under mGCA) - #152440 (Fix typos and grammar in compiler and build documentation) - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls) - #152554 (Remove `deprecated_safe` and its corresponding feature gate) - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2) - #152563 (Replace "bug" with "issue" in triagebot ping messages) - #152565 (fix missleading error for tuple ctor) Failed merges: - #152512 (core: Implement feature `float_exact_integer_constants`) - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
rust-bors
bot
added
S-waiting-on-author
Contributor
|
☔ The latest upstream changes (presumably #152574) made this pull request unmergeable. Please resolve the merge conflicts. This pull request was unapproved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @JonathanBrouwer another two of them :)