diff --git a/src/libcore/iter.rs b/src/libcore/iter.rs index 93d8d7d6e48a9..3b62c8da1ebe1 100644 --- a/src/libcore/iter.rs +++ b/src/libcore/iter.rs @@ -65,9 +65,10 @@ use cmp; use cmp::Ord; use mem; use num::{ToPrimitive, Int}; -use ops::Add; +use ops::{Add, Deref}; use option::{Option, Some, None}; use uint; + #[deprecated = "renamed to Extend"] pub use self::Extend as Extendable; /// Conversion from an `Iterator` @@ -1021,6 +1022,44 @@ impl MinMaxResult { } } +/// A trait for iterators that contain cloneable elements +pub trait CloneIteratorExt { + /// Creates an iterator that clones the elements it yields. Useful for converting an + /// Iterator<&T> to an Iterator. + fn cloned(self) -> Cloned; +} + + +impl, I: Iterator> CloneIteratorExt for I { + fn cloned(self) -> Cloned { + Cloned { it: self } + } +} + +/// An iterator that clones the elements of an underlying iterator +pub struct Cloned { + it: I, +} + +impl, I: Iterator> Iterator for Cloned { + fn next(&mut self) -> Option { + self.it.next().cloned() + } + + fn size_hint(&self) -> (uint, Option) { + self.it.size_hint() + } +} + +impl, I: DoubleEndedIterator> + DoubleEndedIterator for Cloned { + fn next_back(&mut self) -> Option { + self.it.next_back().cloned() + } +} + +impl, I: ExactSize> ExactSize for Cloned {} + /// A trait for iterators that are cloneable. pub trait CloneableIterator { /// Repeats an iterator endlessly diff --git a/src/libcore/option.rs b/src/libcore/option.rs index 5b1590518f88d..199389730373a 100644 --- a/src/libcore/option.rs +++ b/src/libcore/option.rs @@ -153,6 +153,7 @@ use result::{Result, Ok, Err}; use slice; use slice::AsSlice; use clone::Clone; +use ops::Deref; // Note that this is not a lang item per se, but it has a hidden dependency on // `Iterator`, which is one. The compiler assumes that the `next` method of @@ -694,11 +695,12 @@ impl Option { } } -impl<'a, T: Clone> Option<&'a T> { - /// Maps an Option<&T> to an Option by cloning the contents of the Option<&T>. +impl<'a, T: Clone, D: Deref> Option { + /// Maps an Option to an Option by dereffing and cloning the contents of the Option. + /// Useful for converting an Option<&T> to an Option. #[unstable = "recently added as part of collections reform"] pub fn cloned(self) -> Option { - self.map(|t| t.clone()) + self.map(|t| t.deref().clone()) } } diff --git a/src/libcoretest/iter.rs b/src/libcoretest/iter.rs index 32aff498ba109..d046faa82d405 100644 --- a/src/libcoretest/iter.rs +++ b/src/libcoretest/iter.rs @@ -440,6 +440,23 @@ fn test_rev() { vec![16, 14, 12, 10, 8, 6]); } +#[test] +fn test_cloned() { + let xs = [2u8, 4, 6, 8]; + + let mut it = xs.iter().cloned(); + assert_eq!(it.len(), 4); + assert_eq!(it.next(), Some(2)); + assert_eq!(it.len(), 3); + assert_eq!(it.next(), Some(4)); + assert_eq!(it.len(), 2); + assert_eq!(it.next_back(), Some(8)); + assert_eq!(it.len(), 1); + assert_eq!(it.next_back(), Some(6)); + assert_eq!(it.len(), 0); + assert_eq!(it.next_back(), None); +} + #[test] fn test_double_ended_map() { let xs = [1i, 2, 3, 4, 5, 6]; diff --git a/src/libcoretest/option.rs b/src/libcoretest/option.rs index 6138986e1d185..a5927d47eb0af 100644 --- a/src/libcoretest/option.rs +++ b/src/libcoretest/option.rs @@ -241,14 +241,29 @@ fn test_collect() { assert!(v == None); } +#[test] fn test_cloned() { - let s = 1u32; - let n: Option<&'static u32> = None; - let o = Some(&s); - - assert_eq!(o.clone(), Some(&s)); - assert_eq!(o.cloned(), Some(1u32)); - - assert_eq!(n.clone(), None); - assert_eq!(n.cloned(), None); + let val1 = 1u32; + let mut val2 = 2u32; + let val1_ref = &val1; + let opt_none: Option<&'static u32> = None; + let opt_ref = Some(&val1); + let opt_ref_ref = Some(&val1_ref); + let opt_mut_ref = Some(&mut val2); + + // None works + assert_eq!(opt_none.clone(), None); + assert_eq!(opt_none.cloned(), None); + + // Mutable refs work + assert_eq!(opt_mut_ref.cloned(), Some(2u32)); + + // Immutable ref works + assert_eq!(opt_ref.clone(), Some(&val1)); + assert_eq!(opt_ref.cloned(), Some(1u32)); + + // Double Immutable ref works + assert_eq!(opt_ref_ref.clone(), Some(&val1_ref)); + assert_eq!(opt_ref_ref.clone().cloned(), Some(&val1)); + assert_eq!(opt_ref_ref.cloned().cloned(), Some(1u32)); } \ No newline at end of file