diff --git a/src/librustc/middle/dead.rs b/src/librustc/middle/dead.rs index 1aa2ca9115d2f..32ead26e095b6 100644 --- a/src/librustc/middle/dead.rs +++ b/src/librustc/middle/dead.rs @@ -47,6 +47,7 @@ struct MarkSymbolVisitor<'a, 'tcx: 'a> { struct_has_extern_repr: bool, ignore_non_const_paths: bool, inherited_pub_visibility: bool, + ignore_variant_stack: Vec, } impl<'a, 'tcx> MarkSymbolVisitor<'a, 'tcx> { @@ -59,6 +60,7 @@ impl<'a, 'tcx> MarkSymbolVisitor<'a, 'tcx> { struct_has_extern_repr: false, ignore_non_const_paths: false, inherited_pub_visibility: false, + ignore_variant_stack: vec![], } } @@ -79,7 +81,9 @@ impl<'a, 'tcx> MarkSymbolVisitor<'a, 'tcx> { def::DefPrimTy(_) => (), def::DefVariant(enum_id, variant_id, _) => { self.check_def_id(enum_id); - self.check_def_id(variant_id); + if !self.ignore_variant_stack.contains(&variant_id.node) { + self.check_def_id(variant_id); + } } _ => { self.check_def_id(def.def_id()); @@ -271,6 +275,23 @@ impl<'a, 'tcx, 'v> Visitor<'v> for MarkSymbolVisitor<'a, 'tcx> { visit::walk_expr(self, expr); } + fn visit_arm(&mut self, arm: &ast::Arm) { + if arm.pats.len() == 1 { + let pat = &*arm.pats[0]; + let variants = pat_util::necessary_variants(&self.tcx.def_map, pat); + + // Inside the body, ignore constructions of variants + // necessary for the pattern to match. Those construction sites + // can't be reached unless the variant is constructed elsewhere. + let len = self.ignore_variant_stack.len(); + self.ignore_variant_stack.push_all(&*variants); + visit::walk_arm(self, arm); + self.ignore_variant_stack.truncate(len); + } else { + visit::walk_arm(self, arm); + } + } + fn visit_pat(&mut self, pat: &ast::Pat) { let def_map = &self.tcx.def_map; match pat.node { @@ -392,6 +413,11 @@ fn create_and_seed_worklist(tcx: &ty::ctxt, worklist.push(*id); } for id in reachable_symbols { + // Reachable variants can be dead, because we warn about + // variants never constructed, not variants never used. + if let Some(ast_map::NodeVariant(..)) = tcx.map.find(*id) { + continue; + } worklist.push(*id); } diff --git a/src/librustc/middle/pat_util.rs b/src/librustc/middle/pat_util.rs index 27a30f5cf253c..a3253bf294fa1 100644 --- a/src/librustc/middle/pat_util.rs +++ b/src/librustc/middle/pat_util.rs @@ -189,3 +189,27 @@ pub fn def_to_path(tcx: &ty::ctxt, id: ast::DefId) -> ast::Path { span: DUMMY_SP, }) } + +/// Return variants that are necessary to exist for the pattern to match. +pub fn necessary_variants(dm: &DefMap, pat: &ast::Pat) -> Vec { + let mut variants = vec![]; + walk_pat(pat, |p| { + match p.node { + ast::PatEnum(_, _) | + ast::PatIdent(_, _, None) | + ast::PatStruct(..) => { + match dm.borrow().get(&p.id) { + Some(&PathResolution { base_def: DefVariant(_, id, _), .. }) => { + variants.push(id.node); + } + _ => () + } + } + _ => () + } + true + }); + variants.sort(); + variants.dedup(); + variants +} diff --git a/src/librustc_typeck/check/cast.rs b/src/librustc_typeck/check/cast.rs index 5258a77204d60..8c49daccbb22a 100644 --- a/src/librustc_typeck/check/cast.rs +++ b/src/librustc_typeck/check/cast.rs @@ -99,7 +99,6 @@ enum CastError { NeedViaInt, NeedViaUsize, NonScalar, - RefToMutPtr } impl<'tcx> CastCheck<'tcx> { @@ -161,11 +160,6 @@ impl<'tcx> CastCheck<'tcx> { fcx.infcx().ty_to_string(self.cast_ty)) }, self.expr_ty, None); } - CastError::RefToMutPtr => { - span_err!(fcx.tcx().sess, self.span, E0188, - "cannot cast an immutable reference to a \ - mutable pointer"); - } } } diff --git a/src/test/compile-fail/lint-dead-code-variant.rs b/src/test/compile-fail/lint-dead-code-variant.rs new file mode 100644 index 0000000000000..0116d63caf230 --- /dev/null +++ b/src/test/compile-fail/lint-dead-code-variant.rs @@ -0,0 +1,22 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![deny(dead_code)] + +#[derive(Clone)] +enum Enum { + Variant1, //~ ERROR: variant is never used + Variant2, +} + +fn main() { + let e = Enum::Variant2; + e.clone(); +} diff --git a/src/test/run-pass/lint-dead-code-variant.rs b/src/test/run-pass/lint-dead-code-variant.rs new file mode 100644 index 0000000000000..074c69d87087f --- /dev/null +++ b/src/test/run-pass/lint-dead-code-variant.rs @@ -0,0 +1,22 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![deny(dead_code)] + +enum Foo { + A, + B, +} + +pub fn main() { + match Foo::A { + Foo::A | Foo::B => Foo::B + }; +}