From 80f269259c734d25bb4e9586d1cbde8638dcda26 Mon Sep 17 00:00:00 2001 From: Steve Klabnik Date: Wed, 8 Jul 2015 13:04:41 -0400 Subject: [PATCH] Fix up unsafe section of slice::from_raw_parts Added a proper Unsafety header, as well as mentioning that the pointer shouldn't be null. Fixes #26552 --- src/libcore/slice.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libcore/slice.rs b/src/libcore/slice.rs index a8c995f37cce..797f9c368720 100644 --- a/src/libcore/slice.rs +++ b/src/libcore/slice.rs @@ -1368,10 +1368,14 @@ pub fn mut_ref_slice<'a, A>(s: &'a mut A) -> &'a mut [A] { /// /// The `len` argument is the number of **elements**, not the number of bytes. /// +/// # Unsafety +/// /// This function is unsafe as there is no guarantee that the given pointer is /// valid for `len` elements, nor whether the lifetime inferred is a suitable /// lifetime for the returned slice. /// +/// `p` must be non-null, even for zero-length slices. +/// /// # Caveat /// /// The lifetime for the returned slice is inferred from its usage. To