From 84f9c61c69d311457d7a259be95876f5e4f5825e Mon Sep 17 00:00:00 2001 From: Jonathan Reem Date: Thu, 9 Jul 2015 16:38:55 -0700 Subject: [PATCH 1/2] Implement Borrow for CString and ToOwned for CStr This allows CString and CStr to be used with the Cow type, which is extremely useful when interfacing with C libraries that make extensive use of C-style strings. --- src/libstd/ffi/c_str.rs | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/libstd/ffi/c_str.rs b/src/libstd/ffi/c_str.rs index ffc204ada60fb..1ddd74d3f4f34 100644 --- a/src/libstd/ffi/c_str.rs +++ b/src/libstd/ffi/c_str.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -use borrow::{Cow, ToOwned}; +use borrow::{Cow, ToOwned, Borrow}; use boxed::Box; use clone::Clone; use convert::{Into, From}; @@ -272,6 +272,11 @@ impl fmt::Debug for CString { } } +#[stable(feature = "cstr_borrow", since = "1.3.0")] +impl Borrow for CString { + fn borrow(&self) -> &CStr { self } +} + impl NulError { /// Returns the position of the nul byte in the slice that was provided to /// `CString::new`. @@ -444,6 +449,15 @@ impl Ord for CStr { } } +#[stable(feature = "cstr_borrow", since = "1.3.0")] +impl ToOwned for CStr { + type Owned = CString; + + fn to_owned(&self) -> CString { + unsafe { CString::from_vec_unchecked(self.to_bytes().to_vec()) } + } +} + #[cfg(test)] mod tests { use prelude::v1::*; @@ -515,4 +529,13 @@ mod tests { assert_eq!(CStr::from_ptr(ptr).to_string_lossy(), Owned::(format!("123\u{FFFD}"))); } } + + #[test] + fn to_owned() { + let data = b"123\0"; + let ptr = data.as_ptr() as *const libc::c_char; + + let owned = unsafe { CStr::from_ptr(ptr).to_owned() }; + assert_eq!(owned.as_bytes_with_nul(), data); + } } From 69579e4d37849fe64cbdfc7e40dc614af802704d Mon Sep 17 00:00:00 2001 From: Jonathan Reem Date: Thu, 9 Jul 2015 17:33:00 -0700 Subject: [PATCH 2/2] Test that CStr and CString have equivalent hashes. --- src/libstd/ffi/c_str.rs | 15 +++++++++++++++ src/libstd/lib.rs | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/libstd/ffi/c_str.rs b/src/libstd/ffi/c_str.rs index 1ddd74d3f4f34..f13c10156f579 100644 --- a/src/libstd/ffi/c_str.rs +++ b/src/libstd/ffi/c_str.rs @@ -538,4 +538,19 @@ mod tests { let owned = unsafe { CStr::from_ptr(ptr).to_owned() }; assert_eq!(owned.as_bytes_with_nul(), data); } + + #[test] + fn equal_hash() { + use hash; + + let data = b"123\xE2\xFA\xA6\0"; + let ptr = data.as_ptr() as *const libc::c_char; + let cstr: &'static CStr = unsafe { CStr::from_ptr(ptr) }; + + let cstr_hash = hash::hash::<_, hash::SipHasher>(&cstr); + let cstring_hash = + hash::hash::<_, hash::SipHasher>(&CString::new(&data[..data.len() - 1]).unwrap()); + + assert_eq!(cstr_hash, cstring_hash); + } } diff --git a/src/libstd/lib.rs b/src/libstd/lib.rs index caf3f497e10b4..1e82a03f28630 100644 --- a/src/libstd/lib.rs +++ b/src/libstd/lib.rs @@ -150,7 +150,7 @@ #![feature(wrapping)] #![feature(zero_one)] #![cfg_attr(windows, feature(str_utf16))] -#![cfg_attr(test, feature(float_from_str_radix, range_inclusive, float_extras))] +#![cfg_attr(test, feature(float_from_str_radix, range_inclusive, float_extras, hash_default))] #![cfg_attr(test, feature(test, rustc_private, float_consts))] #![cfg_attr(target_env = "msvc", feature(link_args))]