From d8cc2c1e4f8fa6bd49fe9c395353f9e24c7b51fc Mon Sep 17 00:00:00 2001 From: Alexis Bourget Date: Mon, 1 Jun 2020 16:19:10 +0200 Subject: [PATCH] Add a warning about infinite reading in read_(until|line) --- src/libstd/io/mod.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index ebe6d09023f42..717d2868abf98 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -1883,6 +1883,10 @@ pub trait BufRead: Read { /// /// If successful, this function will return the total number of bytes read. /// + /// This function is blocking and should be used carefully: it is possible for + /// an attacker to continuously send bytes without ever sending the delimiter + /// or EOF. + /// /// # Errors /// /// This function will ignore all instances of [`ErrorKind::Interrupted`] and @@ -1945,6 +1949,10 @@ pub trait BufRead: Read { /// /// If this function returns `Ok(0)`, the stream has reached EOF. /// + /// This function is blocking and should be used carefully: it is possible for + /// an attacker to continuously send bytes without ever sending a newline + /// or EOF. + /// /// # Errors /// /// This function has the same error semantics as [`read_until`] and will