Skip to content

Commit c4efcbe

Browse files
ZalatharZalathar
committed
Forbid *-pass directives in incremental tests
Incremental tests that would have used the `check-pass`, `build-pass`, or `run-pass` directives should instead use a revision name starting with `cpass`/`bpass`/`rpass` as appropriate.
1 parent 2b6f4dd commit c4efcbe

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎src/tests/directives.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ See [Controlling pass/fail expectations](ui.md#controlling-passfail-expectations
7070

7171
| Directive | Explanation | Supported test suites | Possible values |
7272
|-----------------------------|---------------------------------------------|-------------------------------------------|-----------------|
73-
| `check-pass` | Building (no codegen) should pass | `ui`, `crashes`, `incremental` | N/A |
73+
| `check-pass` | Building (no codegen) should pass | `ui`, `crashes` | N/A |
7474
| `check-fail` | Building (no codegen) should fail | `ui`, `crashes` | N/A |
75-
| `build-pass` | Building should pass | `ui`, `crashes`, `codegen`, `incremental` | N/A |
75+
| `build-pass` | Building should pass | `ui`, `crashes`, `codegen` | N/A |
7676
| `build-fail` | Building should fail | `ui`, `crashes` | N/A |
77-
| `run-pass` | Program must exit with code `0` | `ui`, `crashes`, `incremental` | N/A |
77+
| `run-pass` | Program must exit with code `0` | `ui`, `crashes` | N/A |
7878
| `run-fail` | Program must exit with code `1..=127` | `ui`, `crashes` | N/A |
7979
| `run-crash` | Program must crash | `ui` | N/A |
8080
| `run-fail-or-crash` | Program must `run-fail` or `run-crash` | `ui` | N/A |
@@ -90,9 +90,9 @@ comparison](ui.md#output-comparison) and [Rustfix tests](ui.md#rustfix-tests) fo
9090

9191
| Directive | Explanation | Supported test suites | Possible values |
9292
|-----------------------------------|--------------------------------------------------------------------------------------------------------------------------|----------------------------------------------|-----------------------------------------------------------------------------------------|
93-
| `check-run-results` | Check run test binary `run-{pass,fail}` output snapshot | `ui`, `crashes`, `incremental` if `run-pass` | N/A |
94-
| `error-pattern` | Check that output contains a specific string | `ui`, `crashes`, `incremental` if `run-pass` | String |
95-
| `regex-error-pattern` | Check that output contains a regex pattern | `ui`, `crashes`, `incremental` if `run-pass` | Regex |
93+
| `check-run-results` | Check run test binary `run-{pass,fail}` output snapshot | `ui`, `crashes`, `incremental` | N/A |
94+
| `error-pattern` | Check that output contains a specific string | `ui`, `crashes`, `incremental` | String |
95+
| `regex-error-pattern` | Check that output contains a regex pattern | `ui`, `crashes`, `incremental` | Regex |
9696
| `check-stdout` | Check `stdout` against `error-pattern`s from running test binary[^check_stdout] | `ui`, `crashes`, `incremental` | N/A |
9797
| `normalize-stderr-32bit` | Normalize actual stderr (for 32-bit platforms) with a rule `"<raw>" -> "<normalized>"` before comparing against snapshot | `ui`, `incremental` | `"<RAW>" -> "<NORMALIZED>"`, `<RAW>`/`<NORMALIZED>` is regex capture and replace syntax |
9898
| `normalize-stderr-64bit` | Normalize actual stderr (for 64-bit platforms) with a rule `"<raw>" -> "<normalized>"` before comparing against snapshot | `ui`, `incremental` | `"<RAW>" -> "<NORMALIZED>"`, `<RAW>`/`<NORMALIZED>` is regex capture and replace syntax |

0 commit comments

Comments
 (0)