Skip to content

no perf run for rustc PR #90680 #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klensy opened this issue Nov 8, 2021 · 5 comments
Closed

no perf run for rustc PR #90680 #1092

klensy opened this issue Nov 8, 2021 · 5 comments

Comments

@klensy
Copy link
Contributor

klensy commented Nov 8, 2021

For some reason, there no perf run for PR rust-lang/rust#90680. Queue is empty, runs for next and previous PR successfully finished.

@calebcartwright
Copy link
Member

Are perf runs typically executed against PRs that only modify tool submodules/subtrees?

@klensy
Copy link
Contributor Author

klensy commented Nov 8, 2021

I guess it runs on everything, for example it runs on RA updates, rust-lang/rust#90464

@Mark-Simulacrum
Copy link
Member

Yeah, this is some bug -- investigating.

@calebcartwright
Copy link
Member

Fair enough. I guess a more general question would be whether it's desirable to have perf runs for such submodule/subtree only changes?

@Mark-Simulacrum
Copy link
Member

Not entirely sure what happened but the results were posted just now after a manual database adjustment. I think we somehow didn't record the run in the right table, but I don't know what caused that.

We want to run perf on all commits to avoid any accidental regressions, even if we don't really expect it from a particular PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants