-
Notifications
You must be signed in to change notification settings - Fork 152
no perf run for rustc PR #90680 #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are perf runs typically executed against PRs that only modify tool submodules/subtrees? |
I guess it runs on everything, for example it runs on RA updates, rust-lang/rust#90464 |
Yeah, this is some bug -- investigating. |
Fair enough. I guess a more general question would be whether it's desirable to have perf runs for such submodule/subtree only changes? |
Not entirely sure what happened but the results were posted just now after a manual database adjustment. I think we somehow didn't record the run in the right table, but I don't know what caused that. We want to run perf on all commits to avoid any accidental regressions, even if we don't really expect it from a particular PR. |
For some reason, there no perf run for PR rust-lang/rust#90680. Queue is empty, runs for next and previous PR successfully finished.
The text was updated successfully, but these errors were encountered: