Skip to content

Reland "Avoid masking shift amounts" #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjorn3 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1283
Closed

Reland "Avoid masking shift amounts" #1274

bjorn3 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1283
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Sep 1, 2022

https://github.com/bjorn3/rustc_codegen_cranelift/pull/1268 was reverted because the masking was still needed for some types. A fix for this will be part of the upcoming 0.88.0 release of Cranelift, so this PR can be relanded once Cranelift 0.88.0 is released.
@bjorn3 bjorn3 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Sep 1, 2022
@bjorn3 bjorn3 mentioned this issue Sep 1, 2022
Closed
@bjorn3 bjorn3 mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Cranelift 0.88.1 rust-lang/rustc_codegen_cranelift
1 participant
@bjorn3