Skip to content

Don't save *.rs.bk if VCS is detected #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcrichton opened this issue Aug 2, 2016 · 7 comments
Closed

Don't save *.rs.bk if VCS is detected #1114

alexcrichton opened this issue Aug 2, 2016 · 7 comments
Labels

Comments

@alexcrichton
Copy link
Member

We've gotten a few issues on Cargo to add *.rs.bk to the default gitignore, but I personally like to keep that pretty clean and I'd prefer if rustfmt just didn't generate these files by default. Especially if git is detected, and perhaps if the working directory is clean, could bk files not be generated by default?

@tikue
Copy link
Contributor

tikue commented Sep 16, 2016

hear! hear!

@konstin
Copy link

konstin commented Mar 23, 2017

Any progress on that? This should be as simple as checking whether git status --porcelain prints anything to stdout.

@nrc
Copy link
Member

nrc commented Mar 23, 2017

This is not really on my radar, priority-wise. If anyone would like to have a go at this I'd be happy to mentor.

@nrc
Copy link
Member

nrc commented Jun 23, 2017

We're on our way to emitting backup files by default, so I don't think this will be so much of an issue

@nrc nrc added the p-low label Jun 23, 2017
@nrc nrc closed this as completed Nov 2, 2017
@tshepang
Copy link
Member

tshepang commented Nov 3, 2017

@nrc is this rejected?

@nrc
Copy link
Member

nrc commented Nov 3, 2017

@tshepang We don't create bk files by default any more, so I don't think it is that useful (if the user turns on the option, I assume they really want it, not VCS-dependent).

@tshepang
Copy link
Member

tshepang commented Nov 3, 2017

oh, that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants