Move off Syntex

[nrc]

And use libsyntax directly. This means we stop working on stable Rust. However, we can address this by distributing via Rustup instead of Cargo (#1526).

[nrc]

I have a branch that uses libsyntax, not sure if to land or not. Would mean the end of stable rustfmt in the short term.

[nrc]

There are a few test failures due to #1541 and #1542, otherwise seems to be working. Branch is https://github.com/rust-lang-nursery/rustfmt/tree/libsyntax

[nrc]

If we don't merge going to have to keep rebasing that branch :-(

[topecongiro]

Hi, I creaed a branch (https://github.com/topecongiro/rustfmt/tree/libsyntax) from yours, which fixes #1538, #1541 and #1542 (though just giving up for GlobalAsm and MacroDef).
It passes all the tests. If it looks good to you, I will create a PR.

[nrc]

Awesome, please PR it! I think we should leave the MacroDef issue open and the FIXME in place - we should at some point fix that properly.

[topecongiro]

Thanks! I will create a PR shortly.

[topecongiro]

Should I create a PR against master branch?

[nrc]

Should I create a PR against master branch?

No, against libsyntax branch

[topecongiro]

Thanks!

[sanmai-NL]

@nrc: ten days ago you published this blog announcing the transition to libsyntax. Your blog has been covered in the This Week in Rust newsletter.

After some careful experimentation and review, which cost me an hour or so, my conclusion is this:

• The new rustfmt-nightly crate cannot be installed yet, at least not with Cargo using a conventional invocation.
• No guidance in the README of the default branch of this repo (nor on the libsyntax branch, for that matter) on how to actually install/use the libsyntax branch, or what the transition path is (when will it be merged into the default branch, etc.).
• Lots of open issues that relate to this, with promises/suggestions about the pending transition.

I personally can imagine some technical tricks get started, but the transition should be documented.

I hope you understand this can appear a bit disorganized and disappointing in general. You probably tried to avoid this impression. Can you please elucidate the current status? Do you recognize the issues I point out or not? Thanks for your efforts anyway.

[nrc]

@sanmai-NL the transition hasn't happened yet. I'll start today and it should be well-documented by the time I'm done.

[sanmai-NL]

@nrc: Thanks for your effort! The time planning was unclear to me from the announcement.