Skip to content

Respect the line break #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnshi opened this issue Nov 23, 2021 · 1 comment
Closed

Respect the line break #5106

lnshi opened this issue Nov 23, 2021 · 1 comment

Comments

@lnshi
Copy link

lnshi commented Nov 23, 2021

I mean the case like:
Screenshot 2021-11-23 at 17 44 49
or:
Screenshot 2021-11-23 at 17 45 53

In either of these cases there are special intentions the developer groups the values or the function calls: for readability or group by semantics, current rustfmt just totally mess it up with simply calculating the line length....

Personally, I feel the direction that controlling the line length like setting all of these use_small_heuristics rules are pretty useless, maybe just do what gofmt is doing: respecting the line break, only deal with the blank line and indentions.

@calebcartwright
Copy link
Member

calebcartwright commented Nov 23, 2021

Thanks for sharing your perspective, but I'm going to close this as a duplicate of #5085 (amongst various other issues) which raised the same topic within the last ~week.

(edit: corrected the linked issue number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants