WIP: Thread toolchain through to error message

In the component-unavailable error case, we need to report the
full toolchain rather than just the component and target name.
This threads it through and reports it in the error message.

Fixes: #1596

Signed-off-by: Daniel Silverstone <[email protected]>

Author: kinnison

src/rustup-dist/src/dist.rs

@@ -542,6 +542,7 @@ pub fn update_from_dist_<'a>(
                 force_update,
                 &download,
                 download.notify_handler.clone(),
+                &toolchain_str,
             )? {
                 UpdateStatus::Unchanged => Ok(None),
                 UpdateStatus::Changed => Ok(Some(hash)),

src/rustup-dist/src/errors.rs

@@ -106,9 +106,9 @@ error_chain! {
             description("missing package for the target of a rename")
             display("server sent a broken manifest: missing package for the target of a rename {}", name)
         }
-        RequestedComponentsUnavailable(c: Vec<Component>, manifest: Manifest) {
+        RequestedComponentsUnavailable(c: Vec<Component>, manifest: Manifest, toolchain: String) {
             description("some requested components are unavailable to download")
-            display("{}", component_unavailable_msg(&c, &manifest))
+            display("{} for toolchain '{}'", component_unavailable_msg(&c, &manifest), toolchain)
         }
     }
 }

src/rustup-dist/src/manifestation.rs

@@ -111,6 +111,7 @@ impl Manifestation {
         force_update: bool,
         download_cfg: &DownloadCfg,
         notify_handler: &Fn(Notification),
+        toolchain_str: &str,
     ) -> Result<UpdateStatus> {
         // Some vars we're going to need a few times
         let temp_cfg = download_cfg.temp_cfg;
@@ -126,10 +127,10 @@ impl Manifestation {
         }
 
         // Make sure we don't accidentally uninstall the essential components! (see #1297)
-        update.missing_essential_components(&self.target_triple, new_manifest)?;
+        update.missing_essential_components(&self.target_triple, new_manifest, toolchain_str)?;
 
         // Validate that the requested components are available
-        match update.unavailable_components(new_manifest) {
+        match update.unavailable_components(new_manifest, toolchain_str) {
             Ok(_) => {}
             _ if force_update => {}
             Err(e) => return Err(e),
@@ -589,6 +590,7 @@ impl Update {
         &self,
         target_triple: &TargetTriple,
         manifest: &Manifest,
+        toolchain_str: &str,
     ) -> Result<()> {
         let missing_essential_components = ["rustc", "cargo"]
             .iter()
@@ -609,14 +611,15 @@ impl Update {
             return Err(ErrorKind::RequestedComponentsUnavailable(
                 missing_essential_components,
                 manifest.clone(),
+                toolchain_str.to_owned(),
             )
             .into());
         }
 
         Ok(())
     }
 
-    fn unavailable_components(&self, new_manifest: &Manifest) -> Result<()> {
+    fn unavailable_components(&self, new_manifest: &Manifest, toolchain_str: &str) -> Result<()> {
         let mut unavailable_components: Vec<Component> = self
             .components_to_install
             .iter()
@@ -637,6 +640,7 @@ impl Update {
             return Err(ErrorKind::RequestedComponentsUnavailable(
                 unavailable_components,
                 new_manifest.clone(),
+                toolchain_str.to_owned(),
             )
             .into());
         }

src/rustup-dist/tests/dist.rs

@@ -433,6 +433,7 @@ fn update_from_dist_(
         force_update,
         download_cfg,
         download_cfg.notify_handler.clone(),
+        &toolchain.to_string(),
     )
 }
 

src/rustup/toolchain.rs

@@ -678,6 +678,7 @@ impl<'a> Toolchain<'a> {
                 false,
                 &self.download_cfg(),
                 self.download_cfg().notify_handler.clone(),
+                &toolchain.to_string(),
             )?;
 
             Ok(())
@@ -747,6 +748,7 @@ impl<'a> Toolchain<'a> {
                 false,
                 &self.download_cfg(),
                 self.download_cfg().notify_handler.clone(),
+                &toolchain.to_string(),
             )?;
 
             Ok(())

tests/cli-v2.rs

@@ -841,8 +841,9 @@ fn update_unavailable_std() {
             config,
             &["rustup", "update", "nightly", "--no-self-update"],
             &format!(
-                "component 'rust-std' for target '{}' is unavailable for download",
-                trip
+                "component 'rust-std' for target '{}' is unavailable for download for toolchain 'nightly-{}'",
+                trip,
+                trip,
             ),
         );
     });
@@ -869,8 +870,9 @@ fn update_unavailable_force() {
             config,
             &["rustup", "update", "nightly", "--no-self-update"],
             &format!(
-                "component 'rls' for target '{}' is unavailable for download",
-                trip
+                "component 'rls' for target '{}' is unavailable for download for toolchain 'nightly-{}'",
+                trip,
+                trip,
             ),
         );
         expect_ok(