Skip to content

Feature request: Set PATH on Windows when spawning via rustup run #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olson-dan opened this issue Jun 6, 2017 · 2 comments
Closed

Feature request: Set PATH on Windows when spawning via rustup run #1152

olson-dan opened this issue Jun 6, 2017 · 2 comments

Comments

@olson-dan
Copy link

See here: https://github.com/Manishearth/rust-clippy/issues/1815

rustup run could resolve the issue clippy has with needing the PATH set by appending (or prepending?) the requested toolchain's bin folder to PATH before spawning the process. This would make it easier to maintain multiple toolchains without shuffling different PATH configurations.

@Diggsey
Copy link
Contributor

Diggsey commented Jun 6, 2017

You can't cargo install clippy and have it work with multiple toolchains - the problem is that clippy links against the compiler DLLs, and those need to match the toolchain with which clippy itself was compiled, not the toolchain that is currently in use.

There are two solutions, either clippy needs to be distributed as a toolchain component, so that you install clippy once per toolchain, and it automatically has access to the compiler DLLs, or clippy needs to copy the compiler DLLs on which it depends into the output directory as part of the build/installation step.

Dup. of #876 #765 #350 etc. etc.

@Diggsey Diggsey closed this as completed Jun 6, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Jun 6, 2017

That's not quite true. Clippy needs to be run with the toolchain it was built with. But yea, in the long run there'll be another solution on the clippy end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants