-
Notifications
You must be signed in to change notification settings - Fork 287
Compile error on RISC-V due to .insn (llvm<=13 only) #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In my opinion, the problem is that we are using this feature too early, I'm not saying it's wrong to use a new feature, but since almost downstream and users use rust with vanilla LLVM, we should use this feature when LLVM 14 is released. |
In general the functions in However in this case I would accept a PR to change this to a |
The mainstream LLVM has released LLVM 14: https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.0 . |
Thanks, I'm closing this issue as LLVM 14 can compile rust now |
I'd like to create this issue to track the status of compiling
.insn i 0x0F, 0, x0, x0, 0x010
directives, as well aspause
/fence w,0
(these three are aliases)Currently with clang 13.0.1, this error occurs when compiling rust:
This is introduced by 597b8e8. I'm not saying that the commit itself has issues: rust can use this safely because
rust-lang/llvm-project
has cherry-picked the upstream commit to support.insn
: rust-lang/rust#91528. However, for those using clang v13.0.1 (or, let's say, the unmodified llvm toolchain), they may encounter this issue during compiling. Hence, I create this issue as a explanation as well as tracking the status of llvm support for.insn
.The code should compile fine with clang 14.
The text was updated successfully, but these errors were encountered: