Skip to content
This repository was archived by the owner on Nov 18, 2022. It is now read-only.

Formating and building issues #122

Closed
k0pernicus opened this issue Aug 14, 2017 · 3 comments
Closed

Formating and building issues #122

k0pernicus opened this issue Aug 14, 2017 · 3 comments
Labels

Comments

@k0pernicus
Copy link

k0pernicus commented Aug 14, 2017

My code version: Version 1.15.0 (1.15.0).

After a clean installation of rls-vscode (0.2.1.), I don't have build outputs because it seems rustfmt is crashing all the time:

[Error - 7:59:20 PM] Request textDocument/formatting failed.
Message: Reformat failed to complete successfully
Code: -32603 

If I set editor.formatOnSave to false, the plugin seems working.
Otherwise, if I put an error in my program (for example a let statement without semi-colon), the analysis runs but no errors have been found...

My $HOME/.cargo/bin contains racer and rustfmt, which have been properly set.

I am using those parameters:

"editor.formatOnSave": true,
"rust.build_lib": true,
"rust.cfg_test": true,
"rust.show_warnings": true,

For the rustfmt error, I think it is related to #65.
For the build issue... I really don't know.

@k0pernicus k0pernicus changed the title Error output when saving a file Formating and build issues Aug 14, 2017
@k0pernicus k0pernicus changed the title Formating and build issues Formating and building issues Aug 14, 2017
@nrc nrc added the bug label Aug 15, 2017
@nrc
Copy link
Member

nrc commented Aug 15, 2017

Hmm, I imagine if formatting is crashing every time we might not get a chance to build? I've been meaning to fix the rustfmt bug here, hopefully that will fix things.

My $HOME/.cargo/bin contains racer and rustfmt, which have been properly set.

You don't need racer and rustfmt separately installed - the RLS brings its own versions. It shouldn't cause problems though.

@k0pernicus
Copy link
Author

k0pernicus commented Aug 22, 2017

Hi @nrc - thank you for the response!
Sorry for the delay, my laptop crashed, so...
I will try again to install it as soon as I recover it.

@Xanewok
Copy link
Member

Xanewok commented Apr 7, 2019

Integration with Rustfmt has improved in the recent RLS and I can't reproduce this issue. Please reopen if that's still the case.

@Xanewok Xanewok closed this as completed Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants