Merge pull request #557 from thatcomputerguy0101/planar_projection

aloucks · web-flow · commit ff840cbf48d7 · 2024-12-07T14:29:05.000-05:00
Fix planar projection focal calculation
diff --git a/src/projection.rs b/src/projection.rs
@@ -336,7 +336,7 @@ impl<S: BaseFloat> From<PlanarFov<S>> for Matrix4<S> {
         }
 
         let two: S = cast(2).unwrap();
-        let inv_f = Rad::tan(persp.fovy / two);
+        let inv_f = Rad::tan(persp.fovy / two) * two / persp.height;
 
         let focal_point = -inv_f.recip();
 

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ impl<S: BaseFloat> From<PlanarFov<S>> for Matrix4<S> {`
`336`	`336`	`}`
`337`	`337`
`338`	`338`	`let two: S = cast(2).unwrap();`
`339`		`- let inv_f = Rad::tan(persp.fovy / two);`
	`339`	`+ let inv_f = Rad::tan(persp.fovy / two) * two / persp.height;`
`340`	`340`
`341`	`341`	`let focal_point = -inv_f.recip();`
`342`	`342`