Disable Automatic Activation of externref

Starting with Rust 1.82 `reference-types` is always present in the
`target_features` section. The problem is that JS bundlers like Webpack
can't currently handle the `reference-types` proposal. So for now there
should not be any automatic detection of the feature and instead it
should explicitly be enabled by the user.

Author: CryZe

crates/cli-support/src/lib.rs

@@ -323,11 +323,17 @@ impl Bindgen {
                 .context("failed getting Wasm module")?,
         };
 
-        // Enable reference type transformations if the module is already using it.
-        if let Ok(true) = wasm_bindgen_wasm_conventions::target_feature(&module, "reference-types")
-        {
-            self.externref = true;
-        }
+        // FIXME: Starting with Rust 1.82 `reference-types` is always present
+        // in the `target_features` section. The problem is that JS bundlers
+        // like Webpack can't currently handle the `reference-types` proposal.
+        // So for now there should not be any automatic detection of the feature
+        // and instead it should explicitly be enabled by the user.
+
+        // // Enable reference type transformations if the module is already using it.
+        // if let Ok(true) = wasm_bindgen_wasm_conventions::target_feature(&module, "reference-types")
+        // {
+        //     self.externref = true;
+        // }
 
         // Enable multivalue transformations if the module is already using it.
         if let Ok(true) = wasm_bindgen_wasm_conventions::target_feature(&module, "multivalue") {

crates/cli/tests/reference/add.wat

@@ -6,6 +6,6 @@
   (export "memory" (memory 0))
   (export "add_u32" (func $add_u32))
   (export "add_i32" (func $add_i32))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/builder.wat

@@ -7,6 +7,6 @@
   (export "memory" (memory 0))
   (export "__wbg_classbuilder_free" (func $__wbg_classbuilder_free))
   (export "classbuilder_builder" (func $classbuilder_builder))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/constructor.wat

@@ -7,6 +7,6 @@
   (export "memory" (memory 0))
   (export "__wbg_classconstructor_free" (func $__wbg_classconstructor_free))
   (export "classconstructor_new" (func $classconstructor_new))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/empty.wat

@@ -1,6 +1,6 @@
 (module $reference_test.wasm
   (memory (;0;) 16)
   (export "memory" (memory 0))
-  (@custom "target_features" (after export) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after export) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/enums.wat

@@ -10,6 +10,6 @@
   (export "option_enum_echo" (func $option_enum_echo))
   (export "get_name" (func $get_name))
   (export "option_string_enum_echo" (func $option_string_enum_echo))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/import-catch.wat

@@ -9,6 +9,6 @@
   (export "exported" (func $exported))
   (export "__wbindgen_exn_store" (func $__wbindgen_exn_store))
   (export "__wbindgen_add_to_stack_pointer" (func $__wbindgen_add_to_stack_pointer))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/nop.wat

@@ -4,6 +4,6 @@
   (memory (;0;) 17)
   (export "memory" (memory 0))
   (export "nop" (func $nop))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/pointers.wat

@@ -6,6 +6,6 @@
   (export "memory" (memory 0))
   (export "const_pointer" (func $const_pointer))
   (export "mut_pointer" (func $mut_pointer))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )
 

crates/cli/tests/reference/raw.wat

@@ -11,6 +11,6 @@
   (export "__wbg_test_free" (func $__wbg_test_free))
   (export "test_test1" (func $test_test1))
   (export "test_test2" (func $test_test2))
-  (@custom "target_features" (after code) "\02+\0fmutable-globals+\08sign-ext")
+  (@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
 )