Adjust Bluetooth IDL for Rust #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* navigator.bluetooth is optional -- it may be manatory by the WebBluetooth spec, but the Rust code should still be able to handle the errors resulting from a browser not implementing the spec at all without panicking. * requestDevice: While it's marked optional upstream, practically it's mandatory (the default value, an empty dictionary, is not accepted). Contributes-To: wasm-bindgen#2381
Contributor
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.bluetooth is optional -- it may be manatory by the
WebBluetooth spec, but the Rust code should still be able to handle
the errors resulting from a browser not implementing the spec at all
without panicking.
requestDevice: While it's marked optional upstream, practically it's
mandatory (the default value, an empty dictionary, is not accepted).
Contributes-To: #2381
These two don't fully resolve #2381, but the easy parts. The navigator.bluetooth part is necessary in the sense that without this, panics on unsupported browsers need manual workarounds to avoid. The latter is more of a usability thing (keeping name clutter low).