Skip to content

Commit f71ad1a

Browse files
rvaggrvagg
committed
fix: extend timeouts, add debugging (for CI)
1 parent 7e7bfc1 commit f71ad1a

File tree

6 files changed

+122
-11
lines changed

6 files changed

+122
-11
lines changed

‎test/test-bare-async.js‎

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ for (const type of ['cjs', 'esm']) {
1212
const bareAsyncFailureFixture = path.join(__dirname, `fixtures/bare-async-failure${type === 'esm' ? '-esm' : ''}`)
1313

1414
describe(`basic bare-async (${type})`, function () {
15-
this.timeout(20000)
15+
this.timeout(60000)
1616
const expectedTemplate = `
1717
testing is WORKER
1818
✔ test-1.js
@@ -26,6 +26,9 @@ testing bare fixture
2626
const { stdout, code } = await runCli(bareAsyncFixture, '--runner=bare-async')
2727
assert.strictEqual(code, 0, 'exited with zero exit code')
2828
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
29+
if (!stdout.includes(expected)) {
30+
console.error(stdout)
31+
}
2932
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
3033
assert.ok(stdout.includes('Running bare-async page tests with Puppeteer'), 'stdout contains expected output for running in page')
3134
})
@@ -34,6 +37,9 @@ testing bare fixture
3437
const { stdout, code } = await runCli(bareAsyncFixture, '--runner=bare-async --worker --page=false')
3538
assert.strictEqual(code, 0, 'exited with zero exit code')
3639
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
40+
if (!stdout.includes(expected)) {
41+
console.error(stdout)
42+
}
3743
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
3844
assert.ok(stdout.includes('Running bare-async worker tests with Puppeteer'), 'stdout contains expected output for running in page')
3945
})
@@ -42,6 +48,9 @@ testing bare fixture
4248
const { stdout, code } = await runCli(bareAsyncFixture, '--runner=bare-async --serviceworker --page=false')
4349
assert.strictEqual(code, 0, 'exited with zero exit code')
4450
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
51+
if (!stdout.includes(expected)) {
52+
console.error(stdout)
53+
}
4554
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
4655
assert.ok(stdout.includes('Running bare-async serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
4756
})
@@ -51,21 +60,30 @@ testing bare fixture
5160
assert.strictEqual(code, 0, 'exited with zero exit code')
5261

5362
let expected = expectedTemplate.replace(/WORKER/, 'not in worker')
63+
if (!stdout.includes(expected)) {
64+
console.error(stdout)
65+
}
5466
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
5567
assert.ok(stdout.includes('Running bare-async serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
5668

5769
expected = expectedTemplate.replace(/WORKER/, 'in worker')
70+
if (!stdout.includes(expected)) {
71+
console.error(stdout)
72+
}
5873
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
5974
assert.ok(stdout.includes('Running bare-async serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
6075

6176
expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
77+
if (!stdout.includes(expected)) {
78+
console.error(stdout)
79+
}
6280
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
6381
assert.ok(stdout.includes('Running bare-async serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
6482
})
6583
})
6684

6785
describe(`failing bare-async (${type})`, function () {
68-
this.timeout(20000)
86+
this.timeout(60000)
6987
const expectedTemplate = `
7088
testing is WORKER
7189
✔ test-1.js
@@ -81,6 +99,9 @@ testing bare fixture
8199
assert.strictEqual(code, 1, 'exited with non-zero exit code')
82100
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
83101
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
102+
if (!stdout.includes(expected)) {
103+
console.error(stdout)
104+
}
84105
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
85106
assert.ok(stdout.includes('Running bare-async page tests with Puppeteer'), 'stdout contains expected output for running in worker')
86107
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')
@@ -91,6 +112,9 @@ testing bare fixture
91112
assert.strictEqual(code, 1, 'exited with non-zero exit code')
92113
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
93114
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
115+
if (!stdout.includes(expected)) {
116+
console.error(stdout)
117+
}
94118
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
95119
assert.ok(stdout.includes('Running bare-async worker tests with Puppeteer'), 'stdout contains expected output for running in worker')
96120
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')
@@ -101,6 +125,9 @@ testing bare fixture
101125
assert.strictEqual(code, 1, 'exited with non-zero exit code')
102126
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
103127
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
128+
if (!stdout.includes(expected)) {
129+
console.error(stdout)
130+
}
104131
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
105132
assert.ok(stdout.includes('Running bare-async serviceworker tests with Puppeteer'), 'stdout contains expected output for running in worker')
106133
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')

‎test/test-bare-sync.js‎

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ for (const type of ['cjs', 'esm']) {
1212
const bareSyncFailureFixture = path.join(__dirname, `fixtures/bare-sync-failure${type === 'esm' ? '-esm' : ''}`)
1313

1414
describe(`basic bare-sync (${type})`, function () {
15-
this.timeout(20000)
15+
this.timeout(60000)
1616
const expectedTemplate = `
1717
testing is WORKER
1818
✔ test-1.js
@@ -24,6 +24,9 @@ testing bare fixture
2424
const { stdout, code } = await runCli(bareSyncFixture, '--runner=bare-sync')
2525
assert.strictEqual(code, 0, 'exited with zero exit code')
2626
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
27+
if (!stdout.includes(expected)) {
28+
console.error(stdout)
29+
}
2730
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
2831
assert.ok(stdout.includes('Running bare-sync page tests with Puppeteer'), 'stdout contains expected output for running in page')
2932
})
@@ -32,6 +35,9 @@ testing bare fixture
3235
const { stdout, code } = await runCli(bareSyncFixture, '--runner=bare-sync --worker --page=false')
3336
assert.strictEqual(code, 0, 'exited with zero exit code')
3437
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
38+
if (!stdout.includes(expected)) {
39+
console.error(stdout)
40+
}
3541
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
3642
assert.ok(stdout.includes('Running bare-sync worker tests with Puppeteer'), 'stdout contains expected output for running in page')
3743
})
@@ -40,6 +46,9 @@ testing bare fixture
4046
const { stdout, code } = await runCli(bareSyncFixture, '--runner=bare-sync --serviceworker --page=false')
4147
assert.strictEqual(code, 0, 'exited with zero exit code')
4248
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
49+
if (!stdout.includes(expected)) {
50+
console.error(stdout)
51+
}
4352
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
4453
assert.ok(stdout.includes('Running bare-sync serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
4554
})
@@ -49,21 +58,30 @@ testing bare fixture
4958
assert.strictEqual(code, 0, 'exited with zero exit code')
5059

5160
let expected = expectedTemplate.replace(/WORKER/, 'not in worker')
61+
if (!stdout.includes(expected)) {
62+
console.error(stdout)
63+
}
5264
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
5365
assert.ok(stdout.includes('Running bare-sync serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
5466

5567
expected = expectedTemplate.replace(/WORKER/, 'in worker')
68+
if (!stdout.includes(expected)) {
69+
console.error(stdout)
70+
}
5671
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
5772
assert.ok(stdout.includes('Running bare-sync serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
5873

5974
expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
75+
if (!stdout.includes(expected)) {
76+
console.error(stdout)
77+
}
6078
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
6179
assert.ok(stdout.includes('Running bare-sync serviceworker tests with Puppeteer'), 'stdout contains expected output for running in page')
6280
})
6381
})
6482

6583
describe(`failing bare-sync (${type})`, function () {
66-
this.timeout(20000)
84+
this.timeout(60000)
6785
const expectedTemplate = `
6886
testing is WORKER
6987
✔ test-1.js
@@ -77,6 +95,9 @@ testing bare fixture
7795
assert.strictEqual(code, 1, 'exited with non-zero exit code')
7896
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
7997
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
98+
if (!stdout.includes(expected)) {
99+
console.error(stdout)
100+
}
80101
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
81102
assert.ok(stdout.includes('Running bare-sync page tests with Puppeteer'), 'stdout contains expected output for running in worker')
82103
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')
@@ -87,6 +108,9 @@ testing bare fixture
87108
assert.strictEqual(code, 1, 'exited with non-zero exit code')
88109
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
89110
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
111+
if (!stdout.includes(expected)) {
112+
console.error(stdout)
113+
}
90114
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
91115
assert.ok(stdout.includes('Running bare-sync worker tests with Puppeteer'), 'stdout contains expected output for running in worker')
92116
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')
@@ -97,6 +121,9 @@ testing bare fixture
97121
assert.strictEqual(code, 1, 'exited with non-zero exit code')
98122
stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
99123
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
124+
if (!stdout.includes(expected)) {
125+
console.error(stdout)
126+
}
100127
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
101128
assert.ok(stdout.includes('Running bare-sync serviceworker tests with Puppeteer'), 'stdout contains expected output for running in worker')
102129
assert.ok(stderr.includes(expectedStderr), 'stderr contains expected output')

‎test/test-mocha.js‎

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ for (const type of ['cjs', 'esm']) {
1616
const mochaFailureFixture = path.join(__dirname, `fixtures/mocha-failure${type === 'esm' ? '-esm' : ''}`)
1717

1818
describe(`basic mocha (${type})`, function () {
19-
this.timeout(20000)
19+
this.timeout(60000)
2020
const expectedTemplate = `
2121
test suite 1
2222
✅ test case 1
@@ -34,6 +34,9 @@ for (const type of ['cjs', 'esm']) {
3434
const { stdout, code } = await runCli(mochaFixture)
3535
assert.strictEqual(code, 0, 'exited with zero exit code')
3636
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
37+
if (!stdout.includes(expected)) {
38+
console.error(stdout)
39+
}
3740
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
3841
assert.ok(stdout.includes('Running mocha page tests with Puppeteer'), 'stdout contains expected output for running in page')
3942
})
@@ -42,6 +45,9 @@ for (const type of ['cjs', 'esm']) {
4245
const { stdout, code } = await runCli(mochaFixture, '--worker --page=false')
4346
assert.strictEqual(code, 0, 'exited with zero exit code')
4447
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
48+
if (!stdout.includes(expected)) {
49+
console.error(stdout)
50+
}
4551
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
4652
assert.ok(stdout.includes('Running mocha worker tests with Puppeteer'), 'stdout contains expected output for running in worker')
4753
})
@@ -50,6 +56,9 @@ for (const type of ['cjs', 'esm']) {
5056
const { stdout, code } = await runCli(mochaFixture, '--serviceworker --page=false')
5157
assert.strictEqual(code, 0, 'exited with zero exit code')
5258
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
59+
if (!stdout.includes(expected)) {
60+
console.error(stdout)
61+
}
5362
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
5463
assert.ok(stdout.includes('Running mocha serviceworker tests with Puppeteer'), 'stdout contains expected output for running in worker')
5564
})
@@ -59,21 +68,30 @@ for (const type of ['cjs', 'esm']) {
5968
assert.strictEqual(code, 0, 'exited with zero exit code')
6069

6170
let expected = expectedTemplate.replace(/WORKER/, 'not in worker')
71+
if (!stdout.includes(expected)) {
72+
console.error(stdout)
73+
}
6274
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
6375
assert.ok(stdout.includes('Running mocha page tests with Puppeteer'), 'stdout contains expected output for running in page')
6476

6577
expected = expectedTemplate.replace(/WORKER/, 'in worker')
78+
if (!stdout.includes(expected)) {
79+
console.error(stdout)
80+
}
6681
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
6782
assert.ok(stdout.includes('Running mocha worker tests with Puppeteer'), 'stdout contains expected output for running in worker')
6883

6984
expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
85+
if (!stdout.includes(expected)) {
86+
console.error(stdout)
87+
}
7088
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
7189
assert.ok(stdout.includes('Running mocha serviceworker tests with Puppeteer'), 'stdout contains expected output for running in worker')
7290
})
7391
})
7492

7593
describe(`failing mocha (${type})`, function () {
76-
this.timeout(20000)
94+
this.timeout(60000)
7795
const expectedTemplate = `
7896
test suite 1 - worker
7997
✅ is WORKER
@@ -95,6 +113,9 @@ for (const type of ['cjs', 'esm']) {
95113
assert.strictEqual(code, 1, 'exited with non-zero exit code')
96114
stdout = removeTimings(stdout)
97115
const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
116+
if (!stdout.includes(expected)) {
117+
console.error(stdout)
118+
}
98119
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
99120
assert.ok(stdout.includes('Running mocha page tests with Puppeteer'), 'stdout contains expected output for running in worker')
100121
})
@@ -104,6 +125,9 @@ for (const type of ['cjs', 'esm']) {
104125
assert.strictEqual(code, 1, 'exited with non-zero exit code')
105126
stdout = removeTimings(stdout)
106127
const expected = expectedTemplate.replace(/WORKER/, 'in worker')
128+
if (!stdout.includes(expected)) {
129+
console.error(stdout)
130+
}
107131
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
108132
assert.ok(stdout.includes('Running mocha worker tests with Puppeteer'), 'stdout contains expected output for running in worker')
109133
})
@@ -113,6 +137,9 @@ for (const type of ['cjs', 'esm']) {
113137
assert.strictEqual(code, 1, 'exited with non-zero exit code')
114138
stdout = removeTimings(stdout)
115139
const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
140+
if (!stdout.includes(expected)) {
141+
console.error(stdout)
142+
}
116143
assert.ok(stdout.includes(expected), 'stdout contains expected test output')
117144
assert.ok(stdout.includes('Running mocha serviceworker tests with Puppeteer'), 'stdout contains expected output for running in worker')
118145
})

‎test/test-polendina-node.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ for (const type of ['cjs', 'esm']) {
2424
const bareAsyncFailureFixture = path.join(__dirname, `fixtures/bare-async-failure${type === 'esm' ? '-esm' : ''}`)
2525

2626
describe(`polendina-node bare-sync (${type})`, function () {
27-
this.timeout(20000)
27+
this.timeout(60000)
2828
it('pass', async () => {
2929
const expected =
3030
`testing is not in worker
@@ -54,7 +54,7 @@ Took X seconds
5454
})
5555

5656
describe(`polendina-node bare-async (${type})`, function () {
57-
this.timeout(20000)
57+
this.timeout(60000)
5858
it('pass', async () => {
5959
const expected =
6060
`testing is not in worker

0 commit comments

Comments
 (0)