Adding push/pop to 3 tests. Removing pybind#878 from top of pybind11.h (it was/is only needed for 1 test).

Author: rwgk

include/pybind11/pybind11.h

@@ -15,7 +15,6 @@
 //
 #if defined(__INTEL_COMPILER)
 #  pragma warning push
-#  pragma warning disable 878   // incompatible exception specifications
 #  pragma warning disable 2196  // warning #2196: routine is both "inline" and "noinline"
 #elif defined(_MSC_VER)
 #  pragma warning(push)

tests/pybind11_cross_module_tests.cpp

@@ -16,6 +16,10 @@
 #include <numeric>
 #include <utility>
 
+#if defined(__INTEL_COMPILER)
+#    pragma warning push
+#    pragma warning disable 2196 // warning #2196: routine is both "inline" and "noinline"
+#endif
 PYBIND11_MODULE(pybind11_cross_module_tests, m) {
     m.doc() = "pybind11 cross-module test module";
 
@@ -149,3 +153,6 @@ PYBIND11_MODULE(pybind11_cross_module_tests, m) {
     m.def("missing_header_arg", [](const std::vector<float> &) {});
     m.def("missing_header_return", []() { return std::vector<float>(); });
 }
+#if defined(__INTEL_COMPILER)
+#    pragma warning pop
+#endif

tests/pybind11_tests.cpp

@@ -62,6 +62,10 @@ void bind_ConstructorStats(py::module_ &m) {
         ;
 }
 
+#if defined(__INTEL_COMPILER)
+#    pragma warning push
+#    pragma warning disable 2196 // warning #2196: routine is both "inline" and "noinline"
+#endif
 PYBIND11_MODULE(pybind11_tests, m) {
     m.doc() = "pybind11 test module";
 
@@ -89,3 +93,6 @@ PYBIND11_MODULE(pybind11_tests, m) {
     for (const auto &initializer : initializers())
         initializer(m);
 }
+#if defined(__INTEL_COMPILER)
+#    pragma warning pop
+#endif

tests/test_constants_and_functions.cpp

@@ -133,7 +133,14 @@ TEST_SUBMODULE(constants_and_functions, m) {
         ;
     m.def("f1", f1);
     m.def("f2", f2);
+#if defined(__INTEL_COMPILER)
+#    pragma warning push
+#    pragma warning disable 878 // incompatible exception specifications
+#endif
     m.def("f3", f3);
+#if defined(__INTEL_COMPILER)
+#    pragma warning pop
+#endif
     m.def("f4", f4);
 
     // test_function_record_leaks