Updates related to clang-tidy upgrade (to version 18):

pybind/pybind11#5272

Author: rwgk

include/pybind11/detail/cross_extension_shared_state.h

@@ -110,7 +110,7 @@ struct cross_extension_shared_state {
         }
         *payload_pp() = new payload_type();
         get_python_state_dict()[AdapterType::abi_id()]
-            = capsule(payload_pp(), AdapterType::abi_id());
+            = capsule(reinterpret_cast<void *>(payload_pp()), AdapterType::abi_id());
         return **payload_pp();
     }
 

tests/test_class_sh_property_stl.cpp

@@ -20,7 +20,7 @@ struct FieldHolder {
 
 struct VectorFieldHolder {
     std::vector<FieldHolder> vec_fld_hld;
-    VectorFieldHolder() { vec_fld_hld.push_back(FieldHolder{Field{300}}); }
+    VectorFieldHolder() { vec_fld_hld.emplace_back(Field{300}); }
     void reset_at(std::size_t index, int wrapped_int) {
         if (index < vec_fld_hld.size()) {
             vec_fld_hld[index].fld.wrapped_int = wrapped_int;