Skip to content

sagenb 1.1.0 #26499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimpase opened this issue Oct 17, 2018 · 25 comments
Closed

sagenb 1.1.0 #26499

dimpase opened this issue Oct 17, 2018 · 25 comments

Comments

@dimpase
Copy link
Member

dimpase commented Oct 17, 2018

a routine update, incorporating most urgent PRs.

Also, in view of #25382

tarball:
https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2

Depends on #24692
Depends on #25382

CC: @kiwifb

Component: packages: standard

Author: Dima Pasechnik

Branch: 20b0980

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/26499

@dimpase dimpase added this to the sage-8.4 milestone Oct 17, 2018
@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

comment:1

should we also do the downgrade to optional here?

@timokau
Copy link
Contributor

timokau commented Oct 17, 2018

comment:3

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

comment:4

Could someone with python3 sage test this?

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

comment:5

Replying to @timokau:

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

Sorry, no, not yet. I forgot about #25837.

@fchapoton
Copy link
Contributor

comment:6

Replying to @dimpase:

Could someone with python3 sage test this?

There is no need to test with python3: I know that launching sagenb will fail when trying to import "email" module. I would say that py3-compatibility of sagenb has never been closer, but there is still work, and no worker to handle the task..

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

comment:7

I'm adding docs, please stand by...

@dimpase

This comment has been minimized.

@dimpase dimpase changed the title sagenb 1.0.4 sagenb 1.1.0 Oct 17, 2018
@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

Commit: 0f1fbf2

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

Branch: u/dimpase/packages/sagenb110

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

New commits:

7adac2cupdate sagenb to version 1.0.4
059de77trac 25382: remove the sagenb docs from the reference manual.
591e91atrac 25382 remove remaining crosslinks
e2ff902Merge branch 'public/25382' of trac.sagemath.org:sage into nb104
80beebbUpgrade GDB
6769112updated SPKG.txt to note the need for makeinfo
17ab2ceMerge branch 'public/packages/optional/gdb82' of trac.sagemath.org:sage into nb104
0f1fbf2added docs of sagenb

@dimpase
Copy link
Member Author

dimpase commented Oct 17, 2018

Dependencies: #24692, #25382

@dimpase
Copy link
Member Author

dimpase commented Oct 18, 2018

comment:12

admittedly, docs are packed with few short autogenerated .rst files; if anyone is willing to tell me how to use sphinx to generate these, be my guest, I can fix this then.

@kiwifb
Copy link
Member

kiwifb commented Oct 18, 2018

comment:13

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Changed commit from 0f1fbf2 to 20b0980

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

20b0980sphinx must be a dependency

@dimpase
Copy link
Member Author

dimpase commented Oct 18, 2018

comment:15

Replying to @kiwifb:

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

Indeed. Thanks for pointing this out. Fixed in the last commit.

@dimpase dimpase modified the milestones: sage-8.4, sage-8.5 Oct 18, 2018
@kiwifb
Copy link
Member

kiwifb commented Oct 25, 2018

comment:16

Do we go ahead with this or are we waiting for further changes?

@dimpase
Copy link
Member Author

dimpase commented Oct 25, 2018

comment:17

Well, I am waiting for a review on this ticket... :-)

@kiwifb
Copy link
Member

kiwifb commented Oct 25, 2018

comment:18

Looks good to me then :)

@kiwifb
Copy link
Member

kiwifb commented Oct 25, 2018

Reviewer: François Bissey

@vbraun
Copy link
Member

vbraun commented Oct 26, 2018

Changed branch from u/dimpase/packages/sagenb110 to 20b0980

@jdemeyer
Copy link
Contributor

jdemeyer commented Nov 5, 2018

Changed commit from 20b0980 to none

@jdemeyer
Copy link
Contributor

jdemeyer commented Nov 5, 2018

comment:20

How was the "source tarball" ​https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2 created? It doesn't correspond with the github repo. In particular, the repo does not contain a bundled mathjax (as it should be), while the "source tarball" does.

Please comment at #26641.

@jdemeyer
Copy link
Contributor

jdemeyer commented Nov 5, 2018

comment:21

I assume that the "source tarball" from this ticket was created from a non-clean checkout of the sagenb repo. I'll fix that on #26641.

@dimpase
Copy link
Member Author

dimpase commented Nov 5, 2018

comment:22

It has been created using the standard procedure as explained in sagenb hacking docs and uploaded to GitHub.

Naturally it is not quite the same as what you have in GitHub report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants