-
-
Notifications
You must be signed in to change notification settings - Fork 600
sagenb 1.1.0 #26499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
comment:1
should we also do the downgrade to optional here? |
comment:3
You mean downgrading the spkg to optional? Is that actually possible already? |
comment:4
Could someone with python3 sage test this? |
comment:6
Replying to @dimpase:
There is no need to test with python3: I know that launching sagenb will fail when trying to import "email" module. I would say that py3-compatibility of sagenb has never been closer, but there is still work, and no worker to handle the task.. |
comment:7
I'm adding docs, please stand by... |
This comment has been minimized.
This comment has been minimized.
Commit: |
Branch: u/dimpase/packages/sagenb110 |
New commits:
|
comment:12
admittedly, docs are packed with few short autogenerated .rst files; if anyone is willing to tell me how to use sphinx to generate these, be my guest, I can fix this then. |
comment:13
I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Replying to @kiwifb:
Indeed. Thanks for pointing this out. Fixed in the last commit. |
comment:16
Do we go ahead with this or are we waiting for further changes? |
comment:17
Well, I am waiting for a review on this ticket... :-) |
comment:18
Looks good to me then :) |
Reviewer: François Bissey |
Changed branch from u/dimpase/packages/sagenb110 to |
Changed commit from |
comment:20
How was the "source tarball" https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2 created? It doesn't correspond with the github repo. In particular, the repo does not contain a bundled mathjax (as it should be), while the "source tarball" does. Please comment at #26641. |
comment:21
I assume that the "source tarball" from this ticket was created from a non-clean checkout of the sagenb repo. I'll fix that on #26641. |
a routine update, incorporating most urgent PRs.
Also, in view of #25382
tarball:
https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2
Depends on #24692
Depends on #25382
CC: @kiwifb
Component: packages: standard
Author: Dima Pasechnik
Branch:
20b0980
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/26499
The text was updated successfully, but these errors were encountered: