Skip to content

The reason behind wrapping the svg in i tag? #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iremlopsum opened this issue Nov 22, 2017 · 2 comments
Closed

The reason behind wrapping the svg in i tag? #28

iremlopsum opened this issue Nov 22, 2017 · 2 comments

Comments

@iremlopsum
Copy link

What is the reason behind wrapping the svg in an <i> tag?

Just wondering if there is a real reason, or this is just how it worked out?
@sairion
Copy link
Owner

sairion commented May 14, 2018

it may not be needed, because we have React.Fragment now. But until React 15, if you want to put an outerHTML of a SVG element, you definitely need something to wrap. That's the only reason. also it resulted with making raw prop.

@sairion sairion closed this as completed May 14, 2018
@sairion
Copy link
Owner

sairion commented May 14, 2018

facebook/react#12014 it seems it's still not possible to put raw html without wrapping element, I will resume current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sairion @iremlopsum