Skip to content

Commit 382936f

Browse files
committed
graphql-java-kickstart#177 Avoid explicitly inject ObjectMapper to the ObjectMapper
1 parent b8c567a commit 382936f

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/main/java/graphql/servlet/ConfiguringObjectMapperProvider.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ public ObjectMapper provide() {
2323
SerializationFeature.FAIL_ON_EMPTY_BEANS).registerModule(new Jdk8Module());
2424
objectMapperConfigurer.configure(mapper);
2525

26-
InjectableValues.Std injectableValues = new InjectableValues.Std();
27-
injectableValues.addValue(ObjectMapper.class, mapper);
28-
mapper.setInjectableValues(injectableValues);
29-
3026
return mapper;
3127
}
3228
}

src/main/java/graphql/servlet/internal/VariablesDeserializer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package graphql.servlet.internal;
22

33
import com.fasterxml.jackson.core.JsonParser;
4+
import com.fasterxml.jackson.core.ObjectCodec;
45
import com.fasterxml.jackson.core.type.TypeReference;
56
import com.fasterxml.jackson.databind.DeserializationContext;
67
import com.fasterxml.jackson.databind.JsonDeserializer;
7-
import com.fasterxml.jackson.databind.ObjectMapper;
88

99
import java.io.IOException;
1010
import java.util.Map;
@@ -15,17 +15,17 @@
1515
public class VariablesDeserializer extends JsonDeserializer<Map<String, Object>> {
1616
@Override
1717
public Map<String, Object> deserialize(JsonParser p, DeserializationContext ctxt) throws IOException {
18-
return deserializeVariablesObject(p.readValueAs(Object.class), (ObjectMapper) ctxt.findInjectableValue(ObjectMapper.class.getName(), null, null));
18+
return deserializeVariablesObject(p.readValueAs(Object.class), p.getCodec());
1919
}
2020

21-
public static Map<String, Object> deserializeVariablesObject(Object variables, ObjectMapper mapper) {
21+
public static Map<String, Object> deserializeVariablesObject(Object variables, ObjectCodec codec) {
2222
if (variables instanceof Map) {
2323
@SuppressWarnings("unchecked")
2424
Map<String, Object> genericVariables = (Map<String, Object>) variables;
2525
return genericVariables;
2626
} else if (variables instanceof String) {
2727
try {
28-
return mapper.readValue((String) variables, new TypeReference<Map<String, Object>>() {});
28+
return codec.readValue(codec.getFactory().createParser((String) variables), new TypeReference<Map<String, Object>>() {});
2929
} catch (IOException e) {
3030
throw new RuntimeException(e);
3131
}

0 commit comments

Comments
 (0)