fix: resolve markdown field rendering issue #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had issues with title hiding logic that was too simplistic and didn't properly account for language validation. This commit introduces a more robust solution that: 1. Integrates with InternationalizedArrayContext to access language configuration 2. Properly validates language IDs by checking against the configured languages 3. Only hides titles when: - The field is a 'value' field (title.toLowerCase() === 'value') - AND the field has a valid language ID that exists in the configured languages 4. Adds proper TypeScript types for language key handling 5. Simplifies the title hiding logic into a single, clear condition The key improvement is that we now validate language IDs against the actual configured languages, ensuring that titles are only hidden for valid language entries. This prevents issues where titles might be incorrectly hidden for invalid or non-language fields. The solution uses the InternationalizedArrayContext to access the language configuration, making it more maintainable and consistent with the rest of the plugin's architecture.
…ge validation and title hiding logic - Add proper type checking for path segments - Improve code readability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #49 by properly handling custom field types in InternationalizedField.
Changes
Problem
The issue was caused by the InternationalizedField component not properly preserving custom field components while applying internationalization features. This was preventing custom field types like markdown from rendering correctly.
Solution
This fix ensures that custom field types like markdown are rendered correctly while maintaining the plugin's internationalization functionality.