Skip to content

[SASSC 2.0] Sass::Script::String #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahorek opened this issue Sep 28, 2018 · 2 comments
Closed

[SASSC 2.0] Sass::Script::String #89

ahorek opened this issue Sep 28, 2018 · 2 comments

Comments

@ahorek
Copy link

ahorek commented Sep 28, 2018

Hi @csuhta
I tested your PR #85 and found out that you removed Sass::Script::String references in favor of Sass::Script::Value::String
https://github.com/sass/sassc-ruby/pull/85/files#diff-36146a65a77915929f0dd69a9bb0c214L42

but the change makes it incompatible with sprockets
https://github.com/rails/sprockets/blob/master/lib/sprockets/sass_processor.rb#L149

should we make the change in sprockets or sassc?

@bolandrm
Copy link
Member

Hey @ahorek ,

There would have to be a change made to sprockets in order to support this. In the mean time, I'm working on update SassC-Rails, which overrides Sprockets to support the new class names.

sass/sassc-rails#109

@ahorek
Copy link
Author

ahorek commented Sep 28, 2018

great, thanks!

@ahorek ahorek closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants