Represent empty XML elements in short form

[scabug]

current:

scala> <abc/>
res0: scala.xml.Elem = <abc></abc>

after patch:

scala> <abc/>
res0: scala.xml.Elem = <abc/>

[scabug]

Imported From: https://issues.scala-lang.org/browse/SI-1118?orig=1
Reporter: brian (brian0)
Assignee: @acruise
Attachments:

• scala-xml-t1118_2.patch (created on Mar 28, 2010 4:01:12 AM UTC, 27889 bytes)
• scala-xml-t1118.patch (created on Mar 19, 2010 6:45:02 AM UTC, 19526 bytes)
• xml-empty-element-short.patch (created on Jul 18, 2008 8:53:30 AM UTC, 916 bytes)

[scabug]

Geoffrey Alan Washburn (washburn) said:
Philipp I think you're handling reviews of changes to library code, so I've reassigned this to you.

[scabug]

@paulp said:
As long as scala isn't tracking how the element was originally represented (and it isn't - whether it should, I do not know) this looks like an easy win. Patch applied in r17612.

[scabug]

@paulp said:
Reopening because it caused the problems described here:

http://www.nabble.com/The-scaladoc-files-generated-by-Scala-2.8.0-are-not-visible-on--Firefox.-td23555632.html

Assigning to myself, opened so I don't forget.

[scabug]

@acruise said:
A new patch against trunk @ 21213, hopefully better handling of empty tags

[scabug]

@acruise said:
With this patch (submitted here for review, not committed yet!), the originally parsed emptiness modes of elements are now preserved on output:

Welcome to Scala version 2.8.0.r21213-b20100318230317 (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_17).
Type in expressions to have them evaluated.
Type :help for more information.

scala> <hi>there <man/><how></how>'s it going?</hi>
res0: scala.xml.Elem = <hi>there <man/><how></how>'s it going?</hi>

Please note that this version of the patch does not (yet) make any changes to tests, so some of them will probably fail until I update it tomorrow.

If people are happy with this approach, I'll update the tests (and write a few more) and throw it out for wider comment.

[scabug]

@acruise said:
Oops, previous one was old; this is new

[scabug]

@acruise said:
Can I get some feedback on my patch? It addresses this issue, adds another test, and is basically ready to commit.

[scabug]

@paulbutcher said:
I just fell into this hole. After much searching of the documentation, I finally stumbled across:

xml.Utility.toXML(x, minimizeTags = true)

I wonder why this is a method in Utility, and not on Node (hich would be much more convenient and discoverable)?

[scabug]

@acruise said:
I brought my patch up to date with master, https://github.com/acruise/scala/tree/t1118. It compiles, tests pass (for me at least!) and it works:

acruise@acruise-PC ~/dev
$ scala
Welcome to Scala version -unknown- (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_31).
Type in expressions to have them evaluated.
Type :help for more information.

scala> <hithere/>
res0: scala.xml.Elem = <hithere/>

[scabug]

@paulp said:
If you add some testing for the functionality being added and send me a pull request, I'll incorporate it.

[scabug]

@acruise said:
Cool! There is a test, but it was in the wrong directory. I've moved it and made it a little less cutesy, just merging and retesting now.

[scabug]

@acruise said:
My fix was merged to master a few days ago, it should ship in 2.10.

[scabug]

@SethTisue said:
For the same issue but with PrettyPrinter, see scala/scala-xml#46