Skip to content

Commit 7cd301c

Browse files
authored
Merge pull request #286 from sjrd/scalajs-use-nodejs-everywhere
Use "nodejs" in all Scala.js projects that testSuite depends on.
2 parents 203be01 + f059eb0 commit 7cd301c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

common.conf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,8 +549,10 @@ build += {
549549
// - Disable fatal Scaladoc warnings, also fragile
550550
"removeScalacOptions -Xfatal-warnings",
551551
// - Use Node.js with the executable "nodejs" instead of "node" (environmental in the CI infrastructure)
552-
// We disable source map tests to save ourselves a `npm install source-map-support` on the workers
553-
"set jsEnv in testSuite := NodeJSEnv(executable = \"nodejs\").value.withSourceMap(false)"
552+
// We disable source map tests to save ourselves a `npm install source-map-support` on the workers.
553+
// Although only `testSuite` actually has tests, dbuild will try to run the tests for all projects
554+
// that `testSuite` depends on (transitively), so we need to set it in a bunch of places.
555+
"set Seq(library, testInterface, jUnitRuntime, testSuite).map(p => jsEnv in p := NodeJSEnv(executable = \"nodejs\").value.withSourceMap(false))"
554556
]
555557
}
556558
}

0 commit comments

Comments
 (0)