Skip to content

include more of Lift, not just lift-json #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Aug 3, 2017 · 5 comments
Closed

include more of Lift, not just lift-json #582

SethTisue opened this issue Aug 3, 2017 · 5 comments

Comments

@SethTisue
Copy link
Member

see prior discussion with @joescii at scala/scala-xml#150. cc @Shadowfiend

this isn't something I can personally take on; I can sometimes to afford to take on things like lift-json, but 1) since Lift is a whole framework with a big complicated build, and 2) since Lift doesn't typically have open-source downstream dependencies, the cost/benefit isn't there for me.

on the other hand, I'm more than happy to offer as much help and advice as I can if you guys want to take a stab at adding it. and once it gets in, I can generally do light maintenance on it myself and notify you if there are problems.

the documentation at https://github.com/scala/community-builds/wiki is IMO already pretty solid, and I'm very interested in improving it if shortcomings are called to my attention.

@joescii
Copy link

joescii commented Aug 3, 2017

I'll get a conversation going in the Lift community regarding this issue. Thanks a million, Seth!

@SethTisue
Copy link
Member Author

SethTisue commented Aug 4, 2017

Lift was also affected by scala/bug#10437 . this could have been caught by the community build

...but note that (since it only involves Scala and doesn't involve rebuilding other dependencies) could it also have been caught if Lift included the current Scala nightly in their own CI. see https://stackoverflow.com/a/40622879/86485 for info on using the current nightly

@Shadowfiend
Copy link

Yes, this is also a good point… We'll mull this over and figure out what the best path forward is.

Are there guidelines as to what kind of stuff should be included in the community build vs not?

@SethTisue
Copy link
Member Author

Are there guidelines

yup, https://github.com/scala/community-builds/wiki/Eligibility

@SethTisue
Copy link
Member Author

SethTisue commented Nov 21, 2017

closing for inactivity. happy to reopen if someone wants to take it back up. (I don't think it's something I'll tackle myself.)

if Lift wants to include "latest Scala nightly" in their CI matrix, the ticket where we're gathering lore on that is https://github.com/scala/community-builds/issues/599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants