Skip to content

JLine 3: switch to "fine-grained" JARs? #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Mar 5, 2020 · 2 comments
Closed

JLine 3: switch to "fine-grained" JARs? #681

SethTisue opened this issue Mar 5, 2020 · 2 comments
Labels
t:repl JLine 3 upgrade (scala/scala#8036)

Comments

@SethTisue
Copy link
Member

SethTisue commented Mar 5, 2020

on the big PR @som-snytt wrote:

Also relevant is the todo for separate REPL jar,
and whether to use the "fine-grained" jline jars

separate REPL JAR seems out of scope to me at the moment, but perhaps someone wants to speak up for it

@som-snytt what are fine-grained jline jars?

@SethTisue SethTisue added the t:repl JLine 3 upgrade (scala/scala#8036) label Mar 5, 2020
@SethTisue
Copy link
Member Author

what are fine-grained jline jars?

ah, this is documented at https://github.com/jline/jline3#artifacts

the jar size difference is

264K	jline-2.14.6.jar
716K	jline-3.12.1.jar

probably not a blocker for 2.13.2, but a possible later refinement, to cut this down?

@SethTisue SethTisue changed the title JLine 3: decide on packaging JLine 3: switch to "fine-grained" JARs? Mar 25, 2020
@SethTisue
Copy link
Member Author

meh, I don't think we need to leave this open. just using the combined JAR has the substantial advantage of simplicity, for both users and maintainers. and we know from scala/bug#11654 that the JLine JAR is only needed when you're actually using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:repl JLine 3 upgrade (scala/scala#8036)
Projects
None yet
Development

No branches or pull requests

1 participant