Skip to content

Move travis.yml/default.yml off sbt-extras, onto official launcher #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Mar 8, 2021 · 3 comments · Fixed by #781
Closed

Move travis.yml/default.yml off sbt-extras, onto official launcher #766

SethTisue opened this issue Mar 8, 2021 · 3 comments · Fixed by #781

Comments

@SethTisue
Copy link
Member

SethTisue commented Mar 8, 2021

As per discussion on #765

Yes, there is a risk that somebody's repo will actually be expecting sbt-extras, but I think we should just rip that bandaid off, there is no "good time" to rip it off.

Motivation: sbt-extras is not the standard, and the proliferation of multiple launch scripts (there's a coursier one now, too) is bad for the community. I think we should discourage use or perception of sbt-extras as a de facto default. The official script should be the de facto default. It's fine for sbt-extras to exist as a power-user alternative for those who want it. (And if sbt-extras has some feature that is really so commonly needed, that feature should be ported to the official one.)

@SethTisue
Copy link
Member Author

SethTisue commented Mar 9, 2021

Well, I know that Eugene and I are in the strongly-pro-official-launch-script camp and @dwijnand... isn't necessarily. I guess we've already talked about this multiple times in multiple contexts... but, Dale, do you want to make an argument that's particular to this context?

@dwijnand
Copy link
Member

dwijnand commented Mar 9, 2021

As far as I can see there's no difference in context here so the arguments remain the same.

@SethTisue
Copy link
Member Author

PR: #781

At this point I'm pretty sure I'm the one actually maintaining most of the repos where this is actually used, so I'd like to go forward with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants