PC invalidates previous work on new run #10867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Sep 20, 2024
| @@ -301,6 +301,7 @@ class Global(settings: Settings, _reporter: Reporter, projectName: String = "") | |||
| def isOutOfDate: Boolean = outOfDate | |||
|
|
|||
| def demandNewCompilerRun() = { | |||
| if (!lastWasReload) allSources.foreach(getUnit(_).foreach(reset(_))) | |||
There was a problem hiding this comment.
would it be equivalent to add a boolean param to demandNewCompilerRun and set it true at the callsite in reload?
|
There is |
|
BTW I was curious (or annoyed) about the test; it's not my intention to muck with (or break) the PC. I assumed incorrectly that it would be a mechanism problem that required no special knowledge of PC semantics and operations. |
The "up-to-date" check is not sufficient when fetching doc comments, since a unit may have been typechecked, with doc wrapper trees removed. A test instability was due to whether the scheduler was checked by a callback or the runner thread. One sample file had no parser callbacks at all.
som-snytt
force-pushed
the
sd/840-flaky-presentation-doc
branch
from
27a4ae7 to
11a33e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "up-to-date" check is not sufficient when fetching doc comments, since a unit may have been typechecked, with doc wrapper trees removed.
A test instability was due to whether the scheduler was checked by a callback or the runner thread.
One sample file had no parser callbacks at all.
Probably the change at
demandNewCompilerRuncan be refined, as it matters just for doc comments.askParseis tweaked to submit one file at a time, since otherwise the parser callback on the first job will look for work and start the next parse. (In this test, the chain stopped there because the second file was trivial and invoked no callback.)Fixes scala/scala-dev#840