-
Notifications
You must be signed in to change notification settings - Fork 92
Milestone release 2.0.0-M1 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good to me.
I don't see why not! |
publishing a milestone SGTM. (partly because it's an opportunity to make sure everything is set up properly.)
I don't think sbt-dynver's behavior depends on whether the tags it's looking at have been pushed to any remote, so you should be able to test this locally. |
Ok, thanks I'll work on it. First, I'll try to put together a PR that adds a CHANGLOG.md and adds some notes about 2.0 in the README.md. |
Tag pushed for 2.0.0-M1, the build ran on Travis, and published to Sonatype. There should be a staging repo with the artifacts. |
there were exactly six staging repos, and all of them were already closed. yay sbt-ci-release 👍 I hit "release" six and not seven, though — is it intentional that nothing was published for Dotty? |
Yes, that's intentional: Lines 17 to 24 in e2e709f
|
It seems scala-xml may have switched to sbt-dynver plugin at an awkward time. Previously, the current version in master should have been 2.0.0-SNAPSHOT. After #356,
I've never used sbt-dynver, but I understand that once we have a tag for 2.0.x, it might get back to a 2.0 version number. This might be a good opportunity to publish a milestone release. Ok to publish a tag for 2.0.0-M1? Should we publish the artifacts, as well? Since 1.2.0 was released, there have been some breaking changes in master. There have been various conservative breaking changes to remove deprecated classes and members. This is a good opportunity to publish a milestone release. The benefit of a milestone is that it doesn't commit us to binary compatibility.
The text was updated successfully, but these errors were encountered: