diff --git a/jvm/src/test/scala-2.x/scala/xml/CompilerErrors.scala b/jvm/src/test/scala-2.x/scala/xml/CompilerErrors.scala index 4d3197890..b847a827c 100644 --- a/jvm/src/test/scala-2.x/scala/xml/CompilerErrors.scala +++ b/jvm/src/test/scala-2.x/scala/xml/CompilerErrors.scala @@ -202,7 +202,7 @@ class CompilerTesting { def expectXmlErrors(msgCount: Int, msg: String, code: String) = { val errors = xmlErrorMessages(msg, code) - val errorCount = errors.filter(_ contains msg).length + val errorCount = errors.count(_ contains msg) assert(errorCount == msgCount, s"$errorCount occurrences of \'$msg\' found -- expected $msgCount in:\n${errors mkString "\n"}") } } diff --git a/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala b/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala index 5d38d74e2..0b0bfd8cb 100644 --- a/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala +++ b/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala @@ -20,12 +20,12 @@ object ReuseNodesTest { class OriginalTranformr(rules: RewriteRule*) extends RuleTransformer(rules:_*) { override def transform(ns: Seq[Node]): Seq[Node] = { val xs = ns.toStream map transform - val (xs1, xs2) = xs zip ns span { case (x, n) => unchanged(n, x) } + val (xs1, xs2) = xs.zip(ns).span { case (x, n) => unchanged(n, x) } if (xs2.isEmpty) ns - else (xs1 map (_._2)) ++ xs2.head._1 ++ transform(ns drop (xs1.length + 1)) + else xs1.map(_._2) ++ xs2.head._1 ++ transform(ns.drop(xs1.length + 1)) } - override def transform(n:Node): Seq[Node] = super.transform(n) + override def transform(n: Node): Seq[Node] = super.transform(n) } class ModifiedTranformr(rules: RewriteRule*) extends RuleTransformer(rules:_*) { @@ -35,18 +35,18 @@ object ReuseNodesTest { if (changed.length != ns.length || changed.zip(ns).exists(p => p._1 != p._2)) changed else ns } - override def transform(n:Node): Seq[Node] = super.transform(n) + override def transform(n: Node): Seq[Node] = super.transform(n) } class AlternateTranformr(rules: RewriteRule*) extends RuleTransformer(rules:_*) { override def transform(ns: Seq[Node]): Seq[Node] = { - val xs = ns.toStream map transform - val (xs1, xs2) = xs zip ns span { case (x, n) => unchanged(n, x) } + val xs = ns.toStream.map(transform) + val (xs1, xs2) = xs.zip(ns).span { case (x, n) => unchanged(n, x) } if (xs2.isEmpty) ns - else (xs1 map (_._2)) ++ xs2.head._1 ++ transform(ns drop (xs1.length + 1)) + else xs1.map(_._2) ++ xs2.head._1 ++ transform(ns.drop(xs1.length + 1)) } - override def transform(n:Node): Seq[Node] = super.transform(n) + override def transform(n: Node): Seq[Node] = super.transform(n) } def rewriteRule = new RewriteRule { @@ -68,34 +68,33 @@ object ReuseNodesTest { class ReuseNodesTest { @Theory - def transformReferentialEquality(rt:RuleTransformer) = { + def transformReferentialEquality(rt: RuleTransformer) = { val original =

val tranformed = rt.transform(original) assertSame(original, tranformed) } @Theory - def transformReferentialEqualityOnly(rt:RuleTransformer) = { + def transformReferentialEqualityOnly(rt: RuleTransformer) = { val original = val transformed = rt.transform(original) recursiveAssert(original,transformed) } - def recursiveAssert(original:Seq[Node], transformed:Seq[Node]):Unit = { - original zip transformed foreach { + def recursiveAssert(original: Seq[Node], transformed: Seq[Node]): Unit = { + original.zip(transformed).foreach { case (x, y) => recursiveAssert(x, y) } } - def recursiveAssert(original:Node, transformed:Node):Unit = { + def recursiveAssert(original: Node, transformed: Node): Unit = { transformed.label match { case "changed" => // do nothing expect this node to be changed recursiveAssert(original.child,transformed.child) - case _ => { + case _ => assertSame(original, transformed) - // No need to check for children, node being immuatable + // No need to check for children, node being immuatable // children can't be different if parents are referentially equal - } } } } diff --git a/jvm/src/test/scala/scala/xml/XMLSyntaxTest.scala b/jvm/src/test/scala/scala/xml/XMLSyntaxTest.scala index 5030dcc04..4225545ee 100644 --- a/jvm/src/test/scala/scala/xml/XMLSyntaxTest.scala +++ b/jvm/src/test/scala/scala/xml/XMLSyntaxTest.scala @@ -12,11 +12,11 @@ class XMLSyntaxTestJVM { object parser extends xml.parsing.ConstructingParser(s, false /*ignore ws*/) { override def replacementText(entityName: String): io.Source = { entityName match { - case "nbsp" => io.Source.fromString("\u0160"); - case _ => super.replacementText(entityName); + case "nbsp" => io.Source.fromString("\u0160") + case _ => super.replacementText(entityName) } } - nextch(); // !!important, to initialize the parser + nextch() // !!important, to initialize the parser } val parsed = parser.element(TopScope) // parse the source as element // alternatively, we could call document() diff --git a/jvm/src/test/scala/scala/xml/XMLTest.scala b/jvm/src/test/scala/scala/xml/XMLTest.scala index 3f6eb62ed..812b53680 100644 --- a/jvm/src/test/scala/scala/xml/XMLTest.scala +++ b/jvm/src/test/scala/scala/xml/XMLTest.scala @@ -9,8 +9,6 @@ import org.junit.Assert.assertEquals import java.io.StringWriter import java.io.ByteArrayOutputStream import java.io.StringReader -import scala.collection.Iterable -import scala.collection.Seq import scala.xml.Utility.sort object XMLTestJVM { @@ -19,14 +17,14 @@ object XMLTestJVM { } class XMLTestJVM { - import XMLTestJVM.{ e, sc } + import XMLTestJVM.{e, sc} def Elem(prefix: String, label: String, attributes: MetaData, scope: NamespaceBinding, child: Node*): Elem = scala.xml.Elem.apply(prefix, label, attributes, scope, minimizeEmpty = true, child: _*) lazy val parsedxml1 = XML.load(new InputSource(new StringReader(""))) lazy val parsedxml11 = XML.load(new InputSource(new StringReader(""))) - val xmlFile2 = "Peter BunemanDan SuciuData on ze webJohn MitchellFoundations of Programming Languages"; + val xmlFile2 = "Peter BunemanDan SuciuData on ze webJohn MitchellFoundations of Programming Languages" lazy val parsedxml2 = XML.load(new InputSource(new StringReader(xmlFile2))) @UnitTest @@ -34,9 +32,9 @@ class XMLTestJVM { val c = new Node { def label = "hello" override def hashCode() = - Utility.hashCode(prefix, label, this.attributes.hashCode(), scope.hashCode(), child); - def child = Elem(null, "world", e, sc); - //def attributes = e; + Utility.hashCode(prefix, label, this.attributes.hashCode(), scope.hashCode(), child) + def child = Elem(null, "world", e, sc) + //def attributes = e override def text = "" } @@ -45,7 +43,7 @@ class XMLTestJVM { assertTrue(List(parsedxml1) sameElements List(parsedxml11)) assertTrue(Array(parsedxml1).toList sameElements List(parsedxml11)) - val x2 = "Peter BunemanDan SuciuData on ze web"; + val x2 = "Peter BunemanDan SuciuData on ze web" val i = new InputSource(new StringReader(x2)) val x2p = scala.xml.XML.load(i) @@ -115,10 +113,10 @@ class XMLTestJVM { Elem(null, "title", e, sc, Text("Foundations of Programming Languages")))) assertEquals("Peter BunemanDan SuciuData on ze web", - (parsedxml2 \\ "book") { (n: Node) => (n \ "title") xml_== "Data on ze web" } toString) + (parsedxml2 \\ "book") { (n: Node) => (n \ "title") xml_== "Data on ze web" }.toString) assertTrue( - ((NodeSeq.fromSeq(List(parsedxml2))) \\ "_") sameElements List( + (NodeSeq.fromSeq(List(parsedxml2)) \\ "_") sameElements List( Elem(null, "bib", e, sc, Elem(null, "book", e, sc, Elem(null, "author", e, sc, Text("Peter Buneman")), @@ -144,27 +142,28 @@ class XMLTestJVM { @UnitTest def unparsed = { // println("attribute value normalization") - val xmlAttrValueNorm = ""; + val xmlAttrValueNorm = "" + { - val isrcA = new InputSource(new StringReader(xmlAttrValueNorm)); - val parsedxmlA = XML.load(isrcA); - val c = (parsedxmlA \ "@nom").text.charAt(0); - assertTrue(c == '\u015e'); + val isrcA = new InputSource(new StringReader(xmlAttrValueNorm)) + val parsedxmlA = XML.load(isrcA) + val c = (parsedxmlA \ "@nom").text.charAt(0) + assertTrue(c == '\u015e') } // buraq: if the following test fails with 'character x not allowed', it is // related to the mutable variable in a closures in MarkupParser.parsecharref { - val isr = scala.io.Source.fromString(xmlAttrValueNorm); - val pxmlB = scala.xml.parsing.ConstructingParser.fromSource(isr, false); - val parsedxmlB = pxmlB.element(TopScope); - val c = (parsedxmlB \ "@nom").text.charAt(0); - assertTrue(c == '\u015e'); + val isr = scala.io.Source.fromString(xmlAttrValueNorm) + val pxmlB = scala.xml.parsing.ConstructingParser.fromSource(isr, false) + val parsedxmlB = pxmlB.element(TopScope) + val c = (parsedxmlB \ "@nom").text.charAt(0) + assertTrue(c == '\u015e') } // #60 test by round trip val p = scala.xml.parsing.ConstructingParser.fromSource(scala.io.Source.fromString(""), true) - val n = p.element(new scala.xml.NamespaceBinding("bar", "BAR", scala.xml.TopScope))(0) + val n = p.element(scala.xml.NamespaceBinding("bar", "BAR", scala.xml.TopScope))(0) assertTrue(n.attributes.get("BAR", n, "attr").nonEmpty) } @@ -181,7 +180,7 @@ class XMLTestJVM { assertEquals( """ abc - """, f("a,b,c") toString) + """, f("a,b,c").toString) object Serialize { @throws(classOf[java.io.IOException]) @@ -190,7 +189,7 @@ class XMLTestJVM { val out = new java.io.ObjectOutputStream(ba) out.writeObject(o) out.close() - ba.toByteArray() + ba.toByteArray } @throws(classOf[java.io.IOException]) @throws(classOf[ClassNotFoundException]) @@ -231,7 +230,7 @@ class XMLTestJVM { @UnitTest def serializeElem = { // Elem - val e1 = title; + val e1 = title val _e1: Elem = read(write(e1)) check(e1, _e1) } @@ -250,10 +249,10 @@ class XMLTestJVM { { for (p <- people) yield { p.name } - { p.age.toString() } + { p.age.toString } } - ; + } val people = new AddressBook( @@ -266,7 +265,7 @@ class XMLTestJVM { { people.toXHTML } - ; + val _e2: Elem = read(write(e2)) check(e2, _e2) } @@ -274,24 +273,24 @@ class XMLTestJVM { // t-486 def wsdlTemplate1(serviceName: String): Node = - ; + def wsdlTemplate2(serviceName: String, targetNamespace: String): Node = - ; + def wsdlTemplate4(serviceName: String, targetNamespace: () => String): Node = - ; + @UnitTest def wsdl = { assertEquals(""" - """, wsdlTemplate1("service1") toString) + """, wsdlTemplate1("service1").toString) assertEquals(""" - """, wsdlTemplate2("service2", "target2") toString) + """, wsdlTemplate2("service2", "target2").toString) assertEquals(""" - """, wsdlTemplate4("service4", () => "target4") toString) + """, wsdlTemplate4("service4", () => "target4").toString) } // Issue found with ISO-8859-1 in #121 that was fixed with UTF-8 default @@ -309,7 +308,7 @@ class XMLTestJVM { val streamWriter = new java.io.OutputStreamWriter(outputStream, "UTF-8") XML.write(streamWriter, xml, XML.encoding, false, null) - streamWriter.flush + streamWriter.flush() val inputStream = new java.io.ByteArrayInputStream(outputStream.toByteArray) val streamReader = new java.io.InputStreamReader(inputStream, XML.encoding) @@ -321,13 +320,13 @@ class XMLTestJVM { def t0663 = { val src = scala.io.Source.fromString("") val parser = xml.parsing.ConstructingParser.fromSource(src, true) - assertEquals("", parser.document() toString) + assertEquals("", parser.document().toString) } @UnitTest def t1079 = assertFalse( == ) - import dtd.{ DocType, PublicID } + import dtd.{DocType, PublicID} @UnitTest def t1620 = { @@ -367,8 +366,8 @@ class XMLTestJVM { def backslashSearch(x: xml.Elem) = "root:-" + (x \ "@{nsUri}at") + "-sub:-" + (x \ "sub" \ "@{nsUri}at") + "-" - assertEquals("root:-rootVal-sub:-subVal-", backslashSearch(xml1) toString) - assertEquals("root:-rootVal-sub:-subVal-", backslashSearch(xml2) toString) + assertEquals("root:-rootVal-sub:-subVal-", backslashSearch(xml1)) + assertEquals("root:-rootVal-sub:-subVal-", backslashSearch(xml2)) } @UnitTest @@ -422,15 +421,15 @@ class XMLTestJVM { val bar = scala.xml.Attribute(null, "bar", "2", foo) val ns = scala.xml.NamespaceBinding(null, "uri", scala.xml.TopScope) - assertEquals(""" foo="1"""", foo toString) + assertEquals(""" foo="1"""", foo.toString) assertEquals(null, scala.xml.TopScope.getURI(foo.pre)) - assertEquals(""" bar="2"""", bar remove "foo" toString) - assertEquals(""" foo="1"""", bar remove "bar" toString) - assertEquals(""" bar="2"""", bar remove (null, scala.xml.TopScope, "foo") toString) - assertEquals(""" foo="1"""", bar remove (null, scala.xml.TopScope, "bar") toString) - assertEquals(""" bar="2" foo="1"""", bar toString) - assertEquals(""" bar="2" foo="1"""", bar remove (null, ns, "foo") toString) - assertEquals(""" bar="2" foo="1"""", bar remove (null, ns, "bar") toString) + assertEquals(""" bar="2"""", bar.remove("foo").toString) + assertEquals(""" foo="1"""", bar.remove("bar").toString) + assertEquals(""" bar="2"""", bar.remove(null, scala.xml.TopScope, "foo").toString) + assertEquals(""" foo="1"""", bar.remove(null, scala.xml.TopScope, "bar").toString) + assertEquals(""" bar="2" foo="1"""", bar.toString) + assertEquals(""" bar="2" foo="1"""", bar.remove(null, ns, "foo").toString) + assertEquals(""" bar="2" foo="1"""", bar.remove(null, ns, "bar").toString) } @UnitTest @@ -450,15 +449,15 @@ class XMLTestJVM { @UnitTest def t7074 = { - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) - assertEquals("""""", sort() toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) + assertEquals("""""", sort().toString) } @UnitTest @@ -485,20 +484,20 @@ class XMLTestJVM { assertEquals(xml1, xml2) assertEquals(xml1, xml3) - assertEquals("""""", noAttr toString) - assertEquals("""""", attrNull toString) - assertEquals("""""", attrNone toString) - assertEquals("""""", preAttrNull toString) - assertEquals("""""", preAttrNone toString) - assertEquals("""""", xml1 toString) - assertEquals("""""", xml2 toString) - assertEquals("""""", xml3 toString) + assertEquals("""""", noAttr.toString) + assertEquals("""""", attrNull.toString) + assertEquals("""""", attrNone.toString) + assertEquals("""""", preAttrNull.toString) + assertEquals("""""", preAttrNone.toString) + assertEquals("""""", xml1.toString) + assertEquals("""""", xml2.toString) + assertEquals("""""", xml3.toString) // Check if attribute order is retained - assertEquals("""""", toString) - assertEquals("""""", toString) - assertEquals("""""", toString) - assertEquals("""""", toString) + assertEquals("""""", .toString) + assertEquals("""""", .toString) + assertEquals("""""", .toString) + assertEquals("""""", .toString) } import java.io.{ Console => _, _ } @@ -507,9 +506,9 @@ class XMLTestJVM { def dontLoop: Unit = { val xml = " " val sink = new PrintStream(new ByteArrayOutputStream()) - (Console withOut sink) { - (Console withErr sink) { - ConstructingParser.fromSource((io.Source fromString xml), true).document().docElem + Console.withOut(sink) { + Console.withErr(sink) { + ConstructingParser.fromSource(io.Source.fromString(xml), preserveWS = true).document().docElem } } } @@ -643,7 +642,7 @@ class XMLTestJVM { parserFactory.setNamespaceAware(namespaceAware) parserFactory.setXIncludeAware(namespaceAware) - assertEquals(xml, XML.withSAXParser(parserFactory.newSAXParser()).loadString(xml).toString()) + assertEquals(xml, XML.withSAXParser(parserFactory.newSAXParser).loadString(xml).toString()) } @UnitTest diff --git a/shared/src/main/scala/scala/xml/Attribute.scala b/shared/src/main/scala/scala/xml/Attribute.scala index e73c6c8b9..f2506d193 100644 --- a/shared/src/main/scala/scala/xml/Attribute.scala +++ b/shared/src/main/scala/scala/xml/Attribute.scala @@ -53,7 +53,7 @@ object Attribute { * * @author Burak Emir */ -abstract trait Attribute extends MetaData { +trait Attribute extends MetaData { def pre: String // will be null if unprefixed val key: String val value: Seq[Node] diff --git a/shared/src/main/scala/scala/xml/Comment.scala b/shared/src/main/scala/scala/xml/Comment.scala index 52b6e787d..6a80c20cb 100644 --- a/shared/src/main/scala/scala/xml/Comment.scala +++ b/shared/src/main/scala/scala/xml/Comment.scala @@ -31,7 +31,7 @@ case class Comment(commentText: String) extends SpecialNode { if (commentText.contains("--")) { throw new IllegalArgumentException("text contains \"--\"") } - if (commentText.length > 0 && commentText.charAt(commentText.length - 1) == '-') { + if (commentText.nonEmpty && commentText.charAt(commentText.length - 1) == '-') { throw new IllegalArgumentException("The final character of a XML comment may not be '-'. See https://www.w3.org/TR/xml11//#IDA5CES") } diff --git a/shared/src/main/scala/scala/xml/Elem.scala b/shared/src/main/scala/scala/xml/Elem.scala index 9015c4b9e..630aeb16f 100755 --- a/shared/src/main/scala/scala/xml/Elem.scala +++ b/shared/src/main/scala/scala/xml/Elem.scala @@ -100,7 +100,8 @@ class Elem( attributes: MetaData = this.attributes, scope: NamespaceBinding = this.scope, minimizeEmpty: Boolean = this.minimizeEmpty, - child: Seq[Node] = this.child.toSeq): Elem = Elem(prefix, label, attributes, scope, minimizeEmpty, child: _*) + child: Seq[Node] = this.child + ): Elem = Elem(prefix, label, attributes, scope, minimizeEmpty, child: _*) /** * Returns concatenation of `text(n)` for each child `n`. diff --git a/shared/src/main/scala/scala/xml/MetaData.scala b/shared/src/main/scala/scala/xml/MetaData.scala index c36587fc3..46ef8c62b 100644 --- a/shared/src/main/scala/scala/xml/MetaData.scala +++ b/shared/src/main/scala/scala/xml/MetaData.scala @@ -134,7 +134,7 @@ abstract class MetaData /** if owner is the element of this metadata item, returns namespace */ def getNamespace(owner: Node): String - def hasNext = (Null != next) + def hasNext = Null != next def length: Int = length(0) diff --git a/shared/src/main/scala/scala/xml/NamespaceBinding.scala b/shared/src/main/scala/scala/xml/NamespaceBinding.scala index 7a750d37c..94caeb238 100644 --- a/shared/src/main/scala/scala/xml/NamespaceBinding.scala +++ b/shared/src/main/scala/scala/xml/NamespaceBinding.scala @@ -42,7 +42,7 @@ case class NamespaceBinding(prefix: String, uri: String, parent: NamespaceBindin def getPrefix(_uri: String): String = if (_uri == uri) prefix else parent getPrefix _uri - override def toString(): String = sbToString(buildString(_, TopScope)) + override def toString: String = sbToString(buildString(_, TopScope)) private def shadowRedefined(stop: NamespaceBinding): NamespaceBinding = { def prefixList(x: NamespaceBinding): List[String] = @@ -50,7 +50,7 @@ case class NamespaceBinding(prefix: String, uri: String, parent: NamespaceBindin else x.prefix :: prefixList(x.parent) def fromPrefixList(l: List[String]): NamespaceBinding = l match { case Nil => stop - case x :: xs => new NamespaceBinding(x, this.getURI(x), fromPrefixList(xs)) + case x :: xs => NamespaceBinding(x, this.getURI(x), fromPrefixList(xs)) } val ps0 = prefixList(this).reverse val ps = ps0.distinct @@ -80,8 +80,8 @@ case class NamespaceBinding(prefix: String, uri: String, parent: NamespaceBindin if (List(null, stop, TopScope).contains(this)) return val s = " xmlns%s=\"%s\"".format( - (if (prefix != null) ":" + prefix else ""), - (if (uri != null) uri else "") + if (prefix != null) ":" + prefix else "", + if (uri != null) uri else "" ) parent.doBuildString(sb append s, stop) // copy(ignore) } diff --git a/shared/src/main/scala/scala/xml/NodeSeq.scala b/shared/src/main/scala/scala/xml/NodeSeq.scala index 7f7daf638..4ccbab390 100644 --- a/shared/src/main/scala/scala/xml/NodeSeq.scala +++ b/shared/src/main/scala/scala/xml/NodeSeq.scala @@ -60,7 +60,7 @@ abstract class NodeSeq extends AbstractSeq[Node] with immutable.Seq[Node] with S val these = this.iterator val those = that.iterator while (these.hasNext && those.hasNext) - if (these.next xml_!= those.next) + if (these.next() xml_!= those.next()) return false !these.hasNext && !those.hasNext @@ -118,11 +118,11 @@ abstract class NodeSeq extends AbstractSeq[Node] with immutable.Seq[Node] with S NodeSeq fromSeq (this flatMap (_.child) filter cond) that match { - case "" => fail - case "_" => makeSeq(!_.isAtom) - case "@" => fail - case _ if (that(0) == '@' && this.length == 1) => atResult - case _ => makeSeq(_.label == that) + case "" => fail + case "_" => makeSeq(!_.isAtom) + case "@" => fail + case _ if that(0) == '@' && this.length == 1 => atResult + case _ => makeSeq(_.label == that) } } diff --git a/shared/src/main/scala/scala/xml/PrettyPrinter.scala b/shared/src/main/scala/scala/xml/PrettyPrinter.scala index c99893d5e..90b683ddb 100755 --- a/shared/src/main/scala/scala/xml/PrettyPrinter.scala +++ b/shared/src/main/scala/scala/xml/PrettyPrinter.scala @@ -38,7 +38,7 @@ class PrettyPrinter(width: Int, step: Int, minimizeEmpty: Boolean) { class Item case object Break extends Item { - override def toString() = "\\" + override def toString = "\\" } case class Box(col: Int, s: String) extends Item case class Para(s: String) extends Item @@ -146,12 +146,12 @@ class PrettyPrinter(width: Int, step: Int, minimizeEmpty: Boolean) { test.length < width - cur private def doPreserve(node: Node) = - node.attribute(XML.namespace, XML.space).map(_.toString == XML.preserve) getOrElse false + node.attribute(XML.namespace, XML.space).exists(_.toString == XML.preserve) protected def traverse(node: Node, pscope: NamespaceBinding, ind: Int): Unit = node match { case Text(s) if s.trim() == "" => - ; + case _: Atom[_] | _: Comment | _: EntityRef | _: ProcInstr => makeBox(ind, node.toString().trim()) case g@Group(xs) => @@ -186,9 +186,9 @@ class PrettyPrinter(width: Int, step: Int, minimizeEmpty: Boolean) { makeBox(ind, stg.substring(0, len2)) makeBreak() // todo: break the rest in pieces /*{ //@todo - val sq:Seq[String] = stg.split(" "); - val it = sq.iterator; - it.next; + val sq:Seq[String] = stg.split(" ") + val it = sq.iterator + it.next for (c <- it) { makeBox(ind+len2-2, c) makeBreak() diff --git a/shared/src/main/scala/scala/xml/ProcInstr.scala b/shared/src/main/scala/scala/xml/ProcInstr.scala index 2bab1d7ef..04970a229 100644 --- a/shared/src/main/scala/scala/xml/ProcInstr.scala +++ b/shared/src/main/scala/scala/xml/ProcInstr.scala @@ -39,5 +39,5 @@ case class ProcInstr(target: String, proctext: String) extends SpecialNode { * to this stringbuffer. */ override def buildString(sb: StringBuilder) = - sb append "".format(target, (if (proctext == "") "" else " " + proctext)) + sb append "".format(target, if (proctext == "") "" else " " + proctext) } diff --git a/shared/src/main/scala/scala/xml/Utility.scala b/shared/src/main/scala/scala/xml/Utility.scala index 1a5226d69..d95931a8c 100755 --- a/shared/src/main/scala/scala/xml/Utility.scala +++ b/shared/src/main/scala/scala/xml/Utility.scala @@ -247,9 +247,10 @@ object Utility extends AnyRef with parsing.TokenTests { stripComments: Boolean = false, decodeEntities: Boolean = true, preserveWhitespace: Boolean = false, - minimizeTags: MinimizeMode.Value = MinimizeMode.Default): Unit = + minimizeTags: MinimizeMode.Value = MinimizeMode.Default + ): Unit = { - if (children.isEmpty) return + if (children.isEmpty) () else if (children forall isAtomAndNotText) { // add space val it = children.iterator val f = it.next() @@ -265,7 +266,7 @@ object Utility extends AnyRef with parsing.TokenTests { /** * Returns prefix of qualified name if any. */ - final def prefix(name: String): Option[String] = (name indexOf ':') match { + final def prefix(name: String): Option[String] = name.indexOf(':') match { case -1 => None case i => Some(name.substring(0, i)) } @@ -360,7 +361,7 @@ object Utility extends AnyRef with parsing.TokenTests { rfb.clear() unescape(ref, sb) match { case null => - if (sb.length > 0) { // flush buffer + if (sb.nonEmpty) { // flush buffer nb += Text(sb.toString()) sb.clear() } @@ -370,9 +371,9 @@ object Utility extends AnyRef with parsing.TokenTests { } } else sb append c } - if (sb.length > 0) { // flush buffer + if (sb.nonEmpty) { // flush buffer val x = Text(sb.toString()) - if (nb.length == 0) + if (nb.isEmpty) return x else nb += x diff --git a/shared/src/main/scala/scala/xml/XML.scala b/shared/src/main/scala/scala/xml/XML.scala index d93d2ce08..46b5a0ec6 100755 --- a/shared/src/main/scala/scala/xml/XML.scala +++ b/shared/src/main/scala/scala/xml/XML.scala @@ -94,7 +94,7 @@ object XML extends XMLLoader[Elem] { doctype: dtd.DocType = null): Unit = { val fos = new FileOutputStream(filename) - val w = Channels.newWriter(fos.getChannel(), enc) + val w = Channels.newWriter(fos.getChannel, enc) ultimately(w.close())( write(w, node, enc, xmlDecl, doctype) diff --git a/shared/src/main/scala/scala/xml/Xhtml.scala b/shared/src/main/scala/scala/xml/Xhtml.scala index 614720d54..c0ec1d3b9 100644 --- a/shared/src/main/scala/scala/xml/Xhtml.scala +++ b/shared/src/main/scala/scala/xml/Xhtml.scala @@ -57,7 +57,7 @@ object Xhtml { } def shortForm = minimizeTags && - (x.child == null || x.child.length == 0) && + (x.child == null || x.child.isEmpty) && (minimizableElements contains x.label) x match { diff --git a/shared/src/main/scala/scala/xml/dtd/ContentModel.scala b/shared/src/main/scala/scala/xml/dtd/ContentModel.scala index 0981c6875..6910f13a7 100644 --- a/shared/src/main/scala/scala/xml/dtd/ContentModel.scala +++ b/shared/src/main/scala/scala/xml/dtd/ContentModel.scala @@ -38,7 +38,7 @@ object ContentModel extends WordExp { } case class ElemName(name: String) extends Label { - override def toString() = """ElemName("%s")""" format name + override def toString = """ElemName("%s")""" format name } def isMixed(cm: ContentModel) = cond(cm) { case _: MIXED => true } @@ -89,7 +89,7 @@ object ContentModel extends WordExp { } sealed abstract class ContentModel { - override def toString(): String = sbToString(buildString) + override def toString: String = sbToString(buildString) def buildString(sb: StringBuilder): StringBuilder } diff --git a/shared/src/main/scala/scala/xml/dtd/DTD.scala b/shared/src/main/scala/scala/xml/dtd/DTD.scala index 919c8acb3..996e7f325 100644 --- a/shared/src/main/scala/scala/xml/dtd/DTD.scala +++ b/shared/src/main/scala/scala/xml/dtd/DTD.scala @@ -32,9 +32,9 @@ abstract class DTD { var attr: mutable.Map[String, AttListDecl] = new mutable.HashMap[String, AttListDecl]() var ent: mutable.Map[String, EntityDecl] = new mutable.HashMap[String, EntityDecl]() - override def toString() = + override def toString = "DTD [\n%s%s]".format( - Option(externalID) getOrElse "", + Option(externalID).getOrElse(""), decls.mkString("", "\n", "\n") ) } diff --git a/shared/src/main/scala/scala/xml/dtd/Decl.scala b/shared/src/main/scala/scala/xml/dtd/Decl.scala index 5497dbb74..80ebc20d8 100644 --- a/shared/src/main/scala/scala/xml/dtd/Decl.scala +++ b/shared/src/main/scala/scala/xml/dtd/Decl.scala @@ -30,7 +30,7 @@ import Utility.sbToString sealed abstract class Decl sealed abstract class MarkupDecl extends Decl { - override def toString(): String = sbToString(buildString) + override def toString: String = sbToString(buildString) def buildString(sb: StringBuilder): StringBuilder } @@ -60,7 +60,7 @@ case class AttListDecl(name: String, attrs: List[AttrDecl]) * directly. */ case class AttrDecl(name: String, tpe: String, default: DefaultDecl) { - override def toString(): String = sbToString(buildString) + override def toString: String = sbToString(buildString) def buildString(sb: StringBuilder): StringBuilder = { sb append " " append name append ' ' append tpe append ' ' diff --git a/shared/src/main/scala/scala/xml/dtd/DocType.scala b/shared/src/main/scala/scala/xml/dtd/DocType.scala index 3e967f03b..62161a566 100644 --- a/shared/src/main/scala/scala/xml/dtd/DocType.scala +++ b/shared/src/main/scala/scala/xml/dtd/DocType.scala @@ -30,7 +30,7 @@ case class DocType(name: String, extID: ExternalID, intSubset: Seq[dtd.Decl]) { throw new IllegalArgumentException(name + " must be an XML Name") /** returns "<!DOCTYPE + name + extID? + ("["+intSubSet+"]")? >" */ - final override def toString() = { + final override def toString = { def intString = if (intSubset.isEmpty) "" else intSubset.mkString("[", "", "]") diff --git a/shared/src/main/scala/scala/xml/dtd/ExternalID.scala b/shared/src/main/scala/scala/xml/dtd/ExternalID.scala index d47b0b173..467430256 100644 --- a/shared/src/main/scala/scala/xml/dtd/ExternalID.scala +++ b/shared/src/main/scala/scala/xml/dtd/ExternalID.scala @@ -27,7 +27,7 @@ sealed abstract class ExternalID extends parsing.TokenTests { // public != null: PUBLIC " " publicLiteral " " [systemLiteral] // public == null: SYSTEM " " systemLiteral - override def toString(): String = { + override def toString: String = { lazy val quotedSystemLiteral = quoted(systemId) lazy val quotedPublicLiteral = quoted(publicId) diff --git a/shared/src/main/scala/scala/xml/dtd/ValidationException.scala b/shared/src/main/scala/scala/xml/dtd/ValidationException.scala index 3e9af6845..127f5ae2e 100644 --- a/shared/src/main/scala/scala/xml/dtd/ValidationException.scala +++ b/shared/src/main/scala/scala/xml/dtd/ValidationException.scala @@ -25,21 +25,21 @@ object MakeValidationException { value + "\", but document tries \"" + actual + "\"") def fromNonEmptyElement() = - new ValidationException("element should be *empty*") + ValidationException("element should be *empty*") def fromUndefinedElement(label: String) = - new ValidationException("element \"" + label + "\" not allowed here") + ValidationException("element \"" + label + "\" not allowed here") def fromUndefinedAttribute(key: String) = - new ValidationException("attribute " + key + " not allowed here") + ValidationException("attribute " + key + " not allowed here") def fromMissingAttribute(allKeys: Set[String]) = { val sb = new StringBuilder("missing value for REQUIRED attribute") if (allKeys.size > 1) sb.append('s') allKeys foreach (k => sb append "'%s'".format(k)) - new ValidationException(sb.toString()) + ValidationException(sb.toString()) } def fromMissingAttribute(key: String, tpe: String) = - new ValidationException("missing value for REQUIRED attribute %s of type %s".format(key, tpe)) + ValidationException("missing value for REQUIRED attribute %s of type %s".format(key, tpe)) } diff --git a/shared/src/main/scala/scala/xml/dtd/impl/Base.scala b/shared/src/main/scala/scala/xml/dtd/impl/Base.scala index e042e709f..bb5f18329 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/Base.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/Base.scala @@ -58,7 +58,7 @@ private[dtd] abstract class Base { // The empty Sequ. case object Eps extends RegExp { final lazy val isNullable = true - override def toString() = "Eps" + override def toString = "Eps" } /** this class can be used to add meta information to regexps. */ diff --git a/shared/src/main/scala/scala/xml/dtd/impl/DetWordAutom.scala b/shared/src/main/scala/scala/xml/dtd/impl/DetWordAutom.scala index ffd7e27d2..26fd06e07 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/DetWordAutom.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/DetWordAutom.scala @@ -34,7 +34,7 @@ private[dtd] abstract class DetWordAutom[T <: AnyRef] { def isSink(q: Int) = delta(q).isEmpty && default(q) == q def next(q: Int, label: T) = delta(q).getOrElse(label, default(q)) - override def toString() = { + override def toString = { val sb = new StringBuilder("[DetWordAutom nstates=") sb.append(nstates) sb.append(" finals=") diff --git a/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala b/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala index 8cc36cd88..45d984ff0 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala @@ -32,8 +32,8 @@ private[dtd] trait Inclusion[A <: AnyRef] { def inclusion(dfa1: DetWordAutom[A], dfa2: DetWordAutom[A]) = { def encode(q1: Int, q2: Int) = 1 + q1 + q2 * dfa1.nstates - def decode2(c: Int) = (c - 1) / (dfa1.nstates) //integer division - def decode1(c: Int) = (c - 1) % (dfa1.nstates) + def decode2(c: Int) = (c - 1) / dfa1.nstates //integer division + def decode1(c: Int) = (c - 1) % dfa1.nstates var q1 = 0 //dfa1.initstate; // == 0 var q2 = 0 //dfa2.initstate; // == 0 diff --git a/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala b/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala index 5a9f0c089..e413101fb 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala @@ -54,7 +54,7 @@ private[dtd] class SubsetConstruction[T <: AnyRef](val nfa: NondetWordAutom[T]) addFinal(q0) // initial state may also be a final state - while (!rest.isEmpty) { + while (rest.nonEmpty) { val P = rest.head rest = rest.tail // assign a number to this bitset diff --git a/shared/src/main/scala/scala/xml/factory/NodeFactory.scala b/shared/src/main/scala/scala/xml/factory/NodeFactory.scala index c6b1704ba..93746e611 100644 --- a/shared/src/main/scala/scala/xml/factory/NodeFactory.scala +++ b/shared/src/main/scala/scala/xml/factory/NodeFactory.scala @@ -45,7 +45,7 @@ trait NodeFactory[A <: Node] { val hash = Utility.hashCode(pre, name, attrSeq.##, scope.##, children) def cons(old: List[A]) = construct(hash, old, pre, name, attrSeq, scope, children) - (cache get hash) match { + cache.get(hash) match { case Some(list) => // find structurally equal list.find(nodeEquals(_, pre, name, attrSeq, scope, children)) match { case Some(x) => x diff --git a/shared/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala b/shared/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala index 62444f87c..2d4573155 100644 --- a/shared/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala +++ b/shared/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala @@ -51,7 +51,7 @@ object EncodingHeuristics { def readEncodingFromStream(in: InputStream): String = { var ret: String = null val bytesToRead = 1024 // enough to read most XML encoding declarations - def resetAndRet = { in.reset; ret } + def resetAndRet = { in.reset(); ret } // This may fail if there are a lot of space characters before the end // of the encoding declaration @@ -79,7 +79,7 @@ object EncodingHeuristics { // Use Latin-1 (ISO-8859-1) because all byte sequences are legal. val declaration = new String(data, 0, length, "ISO-8859-1") val regexp = """(?m).*?encoding\s*=\s*["'](.+?)['"]""".r - (regexp findFirstMatchIn declaration) match { + regexp.findFirstMatchIn(declaration) match { case None => default case Some(md) => md.subgroups(0) } diff --git a/shared/src/main/scala/scala/xml/include/sax/XIncludeFilter.scala b/shared/src/main/scala/scala/xml/include/sax/XIncludeFilter.scala index de10e7706..e7929d93d 100644 --- a/shared/src/main/scala/scala/xml/include/sax/XIncludeFilter.scala +++ b/shared/src/main/scala/scala/xml/include/sax/XIncludeFilter.scala @@ -16,12 +16,12 @@ package include.sax import scala.xml.include._ -import org.xml.sax.{ Attributes, XMLReader, Locator } -import org.xml.sax.helpers.{ XMLReaderFactory, XMLFilterImpl, NamespaceSupport, AttributesImpl } +import org.xml.sax.{Attributes, Locator, XMLReader} +import org.xml.sax.helpers.{AttributesImpl, NamespaceSupport, XMLFilterImpl, XMLReaderFactory} -import java.io.{ BufferedInputStream, InputStreamReader, IOException, UnsupportedEncodingException } +import java.io.{BufferedInputStream, IOException, InputStreamReader, UnsupportedEncodingException} import java.util.Stack -import java.net.{ URL, MalformedURLException } +import java.net.{MalformedURLException, URL} /** * This is a SAX filter which resolves all XInclude include elements before @@ -92,7 +92,7 @@ class XIncludeFilter extends XMLFilterImpl { // there???? override def setDocumentLocator(locator: Locator): Unit = { locators push locator - val base = locator.getSystemId() + val base = locator.getSystemId try { bases.push(new URL(base)) } catch { @@ -124,7 +124,7 @@ class XIncludeFilter extends XMLFilterImpl { // Adjust bases stack by pushing either the new // value of xml:base or the base of the parent val base = atts.getValue(NamespaceSupport.XMLNS, "base") - val parentBase = bases.peek().asInstanceOf[URL] + val parentBase = bases.peek() var currentBase = parentBase if (base != null) { try { @@ -164,7 +164,7 @@ class XIncludeFilter extends XMLFilterImpl { // add xml:base attribute if necessary val attsImpl = new AttributesImpl(atts) attsImpl.addAttribute(NamespaceSupport.XMLNS, "base", - "xml:base", "CDATA", currentBase.toExternalForm()) + "xml:base", "CDATA", currentBase.toExternalForm) atts = attsImpl atRoot = false } @@ -226,16 +226,16 @@ class XIncludeFilter extends XMLFilterImpl { // convenience method for error messages private def getLocation(): String = { var locationString = "" - val locator = locators.peek().asInstanceOf[Locator] + val locator = locators.peek() var publicID = "" var systemID = "" var column = -1 var line = -1 if (locator != null) { - publicID = locator.getPublicId() - systemID = locator.getSystemId() - line = locator.getLineNumber() - column = locator.getColumnNumber() + publicID = locator.getPublicId + systemID = locator.getSystemId + line = locator.getLineNumber + column = locator.getColumnNumber } locationString = (" in document included from " + publicID + " at " + systemID @@ -261,7 +261,7 @@ class XIncludeFilter extends XMLFilterImpl { if (encoding == null || encoding.trim().equals("")) encoding = "UTF-8" var source: URL = null try { - val base = bases.peek().asInstanceOf[URL] + val base = bases.peek() source = new URL(base, url) } catch { case e: MalformedURLException => @@ -273,9 +273,9 @@ class XIncludeFilter extends XMLFilterImpl { try { val uc = source.openConnection() - val in = new BufferedInputStream(uc.getInputStream()) - val encodingFromHeader = uc.getContentEncoding() - var contentType = uc.getContentType() + val in = new BufferedInputStream(uc.getInputStream) + val encodingFromHeader = uc.getContentEncoding + var contentType = uc.getContentType if (encodingFromHeader != null) encoding = encodingFromHeader else { @@ -305,7 +305,7 @@ class XIncludeFilter extends XMLFilterImpl { + encoding + getLocation(), e) case e: IOException => throw new SAXException("Document not found: " - + source.toExternalForm() + getLocation(), e) + + source.toExternalForm + getLocation(), e) } } @@ -342,7 +342,7 @@ class XIncludeFilter extends XMLFilterImpl { } parser setContentHandler this - val resolver = this.getEntityResolver() + val resolver = this.getEntityResolver if (resolver != null) parser setEntityResolver resolver @@ -357,14 +357,14 @@ class XIncludeFilter extends XMLFilterImpl { bases push source atRoot = true - parser parse source.toExternalForm() + parser parse source.toExternalForm // restore old level and base this.level = previousLevel bases.pop() } catch { case e: IOException => - throw new SAXException("Document not found: " + source.toExternalForm() + getLocation(), e) + throw new SAXException("Document not found: " + source.toExternalForm + getLocation(), e) } } } diff --git a/shared/src/main/scala/scala/xml/include/sax/XIncluder.scala b/shared/src/main/scala/scala/xml/include/sax/XIncluder.scala index a54664002..2dcc69b8c 100644 --- a/shared/src/main/scala/scala/xml/include/sax/XIncluder.scala +++ b/shared/src/main/scala/scala/xml/include/sax/XIncluder.scala @@ -56,7 +56,7 @@ class XIncluder(outs: OutputStream, encoding: String) extends ContentHandler wit def startElement(namespaceURI: String, localName: String, qualifiedName: String, atts: Attributes) = { try { out.write("<" + qualifiedName) - var i = 0; while (i < atts.getLength()) { + var i = 0; while (i < atts.getLength) { out.write(" ") out.write(atts.getQName(i)) out.write("='") diff --git a/shared/src/main/scala/scala/xml/parsing/MarkupHandler.scala b/shared/src/main/scala/scala/xml/parsing/MarkupHandler.scala index 886ee3499..88e30d048 100755 --- a/shared/src/main/scala/scala/xml/parsing/MarkupHandler.scala +++ b/shared/src/main/scala/scala/xml/parsing/MarkupHandler.scala @@ -42,7 +42,7 @@ abstract class MarkupHandler { } def replacementText(entityName: String): Source = - Source fromString ((ent get entityName) match { + Source.fromString(ent.get(entityName) match { case Some(ParsedEntityDecl(_, IntDef(value))) => value case Some(ParameterEntityDecl(_, IntDef(value))) => " %s " format value case Some(_) => "" format entityName @@ -120,10 +120,10 @@ abstract class MarkupHandler { } def parameterEntityDecl(name: String, edef: EntityDef): Unit = - someEntityDecl(name, edef, ParameterEntityDecl.apply _) + someEntityDecl(name, edef, ParameterEntityDecl.apply) def parsedEntityDecl(name: String, edef: EntityDef): Unit = - someEntityDecl(name, edef, ParsedEntityDecl.apply _) + someEntityDecl(name, edef, ParsedEntityDecl.apply) def peReference(name: String): Unit = { decls ::= PEReference(name) } def unparsedEntityDecl(name: String, extID: ExternalID, notat: String): Unit = () diff --git a/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala b/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala index 60b7b5a4b..853897117 100755 --- a/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala +++ b/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala @@ -71,8 +71,8 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { iter.buffered } val iter = new Iterator[Char] { - def hasNext = underlying.hasNext || !queue.isEmpty - def next() = if (!queue.isEmpty) queue.dequeue() else underlying.next() + def hasNext = underlying.hasNext || queue.nonEmpty + def next() = if (queue.nonEmpty) queue.dequeue() else underlying.next() } } @@ -265,7 +265,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { case _: EntityRef => // todo: fix entities, shouldn't be "special" reportSyntaxError("no entity references allowed here") case s: SpecialNode => - if (s.toString.trim().length > 0) //non-empty text nodes not allowed + if (s.toString.trim.nonEmpty) //non-empty text nodes not allowed elemCount += 2 case m: Node => elemCount += 1 @@ -328,7 +328,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { Utility.prefix(qname) match { case Some("xmlns") => val prefix = qname.substring(6 /*xmlns:*/ , qname.length) - scope = new NamespaceBinding(prefix, value, scope) + scope = NamespaceBinding(prefix, value, scope) case Some(prefix) => val key = qname.substring(prefix.length + 1, qname.length) @@ -336,7 +336,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { case _ => if (qname == "xmlns") - scope = new NamespaceBinding(null, value, scope) + scope = NamespaceBinding(null, value, scope) else aMap = new UnprefixedAttribute(qname, Text(value), aMap) } @@ -503,14 +503,14 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { xToken("YSTEM") xSpace() val sysID = systemLiteral() - new SystemID(sysID) + SystemID(sysID) case 'P' => nextch(); xToken("UBLIC") xSpace() val pubID = pubidLiteral() xSpace() val sysID = systemLiteral() - new PublicID(pubID, sysID) + PublicID(pubID, sysID) } /** @@ -934,7 +934,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { systemLiteral() else null - new PublicID(pubID, sysID) + PublicID(pubID, sysID) } else { reportSyntaxError("PUBLIC or SYSTEM expected") truncatedError("died parsing notationdecl") diff --git a/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala b/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala index 1a3886589..c967a5f02 100644 --- a/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala +++ b/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala @@ -164,11 +164,11 @@ private[scala] trait MarkupParserCommon extends TokenTests { * see [66] */ def xCharRef(ch: () => Char, nextch: () => Unit): String = - Utility.parseCharRef(ch, nextch, reportSyntaxError _, truncatedError _) + Utility.parseCharRef(ch, nextch, reportSyntaxError, truncatedError) def xCharRef(it: Iterator[Char]): String = { var c = it.next() - Utility.parseCharRef(() => c, () => { c = it.next() }, reportSyntaxError _, truncatedError _) + Utility.parseCharRef(() => c, () => { c = it.next() }, reportSyntaxError, truncatedError) } def xCharRef: String = xCharRef(() => ch, () => nextch()) diff --git a/shared/src/main/scala/scala/xml/parsing/XhtmlEntities.scala b/shared/src/main/scala/scala/xml/parsing/XhtmlEntities.scala index 89b53d844..c3649f8c6 100644 --- a/shared/src/main/scala/scala/xml/parsing/XhtmlEntities.scala +++ b/shared/src/main/scala/scala/xml/parsing/XhtmlEntities.scala @@ -52,7 +52,7 @@ object XhtmlEntities { val entMap: Map[String, Char] = Map.empty[String, Char] ++ entList.map { case (name, value) => (name, value.toChar) } val entities = entList. - map { case (name, value) => (name, new ParsedEntityDecl(name, new IntDef(value.toChar.toString))) } + map { case (name, value) => (name, ParsedEntityDecl(name, IntDef(value.toChar.toString))) } def apply() = entities } diff --git a/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala b/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala index 53dc8002f..c066d52cc 100644 --- a/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala +++ b/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala @@ -30,7 +30,7 @@ abstract class BasicTransformer extends Function1[Node, Node] { * to NodeBuffer. */ def transform(it: Iterator[Node], nb: NodeBuffer): Seq[Node] = - it.foldLeft(nb)(_ ++= transform(_)).toSeq + it.foldLeft(nb)(_ ++= transform(_)) /** * Call transform(Node) to each node in ns, yield ns if nothing changes, diff --git a/shared/src/test/scala-2.x/scala/xml/TransformersTest.scala b/shared/src/test/scala-2.x/scala/xml/TransformersTest.scala index f8c5b661a..ae1ae1463 100644 --- a/shared/src/test/scala-2.x/scala/xml/TransformersTest.scala +++ b/shared/src/test/scala-2.x/scala/xml/TransformersTest.scala @@ -66,10 +66,9 @@ class TransformersTest { new RuleTransformer(new RewriteRule { override def transform(n: Node): Seq[Node] = { n match { - case t: Text if !t.text.trim.isEmpty => { + case t: Text if t.text.trim.nonEmpty => i += 1 Text(t.text + "!") - } case _ => n } } diff --git a/shared/src/test/scala-2.x/scala/xml/XMLTest2x.scala b/shared/src/test/scala-2.x/scala/xml/XMLTest2x.scala index c7e39b93a..21835506f 100644 --- a/shared/src/test/scala-2.x/scala/xml/XMLTest2x.scala +++ b/shared/src/test/scala-2.x/scala/xml/XMLTest2x.scala @@ -10,7 +10,7 @@ class XMLTest2x { // t-486 def wsdlTemplate3(serviceName: String): Node = - ; + @UnitTest def wsdl = { diff --git a/shared/src/test/scala/scala/xml/AttributeTest.scala b/shared/src/test/scala/scala/xml/AttributeTest.scala index 84cebbeb6..4e151224e 100644 --- a/shared/src/test/scala/scala/xml/AttributeTest.scala +++ b/shared/src/test/scala/scala/xml/AttributeTest.scala @@ -56,8 +56,8 @@ class AttributeTest { def attributeToString: Unit = { val expected: String = """""" - assertEquals(expected, ().toString) - assertEquals(expected, ().toString) + assertEquals(expected, .toString) + assertEquals(expected, .toString) } @Test @@ -102,31 +102,31 @@ class AttributeTest { @Test def attributePathDescendantAttributes: Unit = { val xml = - assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), (xml \\ "@bar")) + assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), xml \\ "@bar") } @Test def attributeDescendantPathChildAttributes: Unit = { val xml = - assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), (xml \ "b" \\ "@bar")) + assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), xml \ "b" \\ "@bar") } @Test def attributeDescendantPathDescendantAttributes: Unit = { val xml = - assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), (xml \\ "b" \\ "@bar")) + assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), xml \\ "b" \\ "@bar") } @Test def attributeChildDescendantPathDescendantAttributes: Unit = { val xml = - assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), (xml \ "a" \\ "@bar")) + assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), xml \ "a" \\ "@bar") } @Test def attributeDescendantDescendantPathDescendantAttributes: Unit = { val xml = - assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), (xml \\ "b" \\ "@bar")) + assertEquals(NodeSeq.fromSeq(Seq(Text("1"), Text("2"))), xml \\ "b" \\ "@bar") } @Test(expected=classOf[IllegalArgumentException]) @@ -138,13 +138,13 @@ class AttributeTest { @Test def attributePathNoDescendantAttributes: Unit = { val xml = - assertEquals(NodeSeq.Empty, (xml \\ "@oops")) + assertEquals(NodeSeq.Empty, xml \\ "@oops") } @Test def attributePathOneChildWithAttributes: Unit = { val xml = > - assertEquals(Group(Seq(Text("1"))), (xml \ "b" \ "@bar")) + assertEquals(Group(Seq(Text("1"))), xml \ "b" \ "@bar") } @Test diff --git a/shared/src/test/scala/scala/xml/CommentTest.scala b/shared/src/test/scala/scala/xml/CommentTest.scala index 0e077a969..b1a6cfe34 100644 --- a/shared/src/test/scala/scala/xml/CommentTest.scala +++ b/shared/src/test/scala/scala/xml/CommentTest.scala @@ -18,12 +18,12 @@ final class CommentTest { @Test def validCommentWithDash: Unit = { val valid: String = "valid-comment" - assertEquals(s"", Comment(valid).toString) + assertEquals(s"", Comment(valid).toString) } @Test def validEmptyComment: Unit = { val valid: String = "" - assertEquals(s"", Comment(valid).toString) + assertEquals(s"", Comment(valid).toString) } } diff --git a/shared/src/test/scala/scala/xml/MetaDataTest.scala b/shared/src/test/scala/scala/xml/MetaDataTest.scala index d6bacc0ef..44c9454d6 100644 --- a/shared/src/test/scala/scala/xml/MetaDataTest.scala +++ b/shared/src/test/scala/scala/xml/MetaDataTest.scala @@ -14,23 +14,23 @@ class MetaDataTest { @Test def absentElementPrefixed2: Unit = { - assertEquals(None, Null.get("za://foo.com", TopScope, "bar" )) - assertEquals(None, Null.get("bar")) + assertEquals(Option.empty, Null.get("za://foo.com", TopScope, "bar" )) + assertEquals(Option.empty, Null.get("bar")) } @Test def presentElement1: Unit = { val x = new PrefixedAttribute("zo","bar", new Atom(42), Null) - val s = new NamespaceBinding("zo","za://foo.com", TopScope) + val s = NamespaceBinding("zo","za://foo.com", TopScope) assertEquals(new Atom(42), x("za://foo.com", s, "bar" )) assertEquals(null, x("bar")) assertEquals(Some(new Atom(42)), x.get("za://foo.com", s, "bar")) - assertEquals(None, x.get("bar")) + assertEquals(Option.empty, x.get("bar")) } @Test def presentElement2: Unit = { - val s = new NamespaceBinding("zo","za://foo.com", TopScope) + val s = NamespaceBinding("zo","za://foo.com", TopScope) val x1 = new PrefixedAttribute("zo","bar", new Atom(42), Null) val x = new UnprefixedAttribute("bar","meaning", x1) assertEquals(null, x(null, s, "bar")) @@ -43,7 +43,7 @@ class MetaDataTest { def attributeExtractor: Unit = { def domatch(x:Node): Node = { x match { - case Node("foo", md @ UnprefixedAttribute(_, value, _), _*) if !value.isEmpty => + case Node("foo", md @ UnprefixedAttribute(_, value, _), _*) if value.nonEmpty => md("bar")(0) case _ => new Atom(3) } diff --git a/shared/src/test/scala/scala/xml/NodeSeqTest.scala b/shared/src/test/scala/scala/xml/NodeSeqTest.scala index 7f80b3366..8fa427363 100644 --- a/shared/src/test/scala/scala/xml/NodeSeqTest.scala +++ b/shared/src/test/scala/scala/xml/NodeSeqTest.scala @@ -46,7 +46,7 @@ class NodeSeqTest { val exp: NodeBuffer = { HelloHi } - assertEquals(exp, res) + assertEquals(exp.toSeq, res) } @Test diff --git a/shared/src/test/scala/scala/xml/PatternMatchingTest.scala b/shared/src/test/scala/scala/xml/PatternMatchingTest.scala index 2fce27208..b2892c9cb 100644 --- a/shared/src/test/scala/scala/xml/PatternMatchingTest.scala +++ b/shared/src/test/scala/scala/xml/PatternMatchingTest.scala @@ -18,7 +18,7 @@ class PatternMatchingTest { } def matchList(args: List[String]) = - Elem(null, "bla", Null, TopScope, minimizeEmpty = true, (args map { x => Text(x) }): _*) match { + Elem(null, "bla", Null, TopScope, minimizeEmpty = true, args.map { x => Text(x) }: _*) match { case Elem(_, _, _, _, Text("1"), _*) => true } @@ -58,9 +58,11 @@ class PatternMatchingTest { object SafeNodeSeq { def unapplySeq(any: Any): Option[Seq[Node]] = any match { - case s: Seq[_] => Some((s flatMap (_ match { - case n: Node => n case _ => NodeSeq.Empty - })).toSeq) case _ => None + case s: Seq[_] => Some(s flatMap { + case n: Node => n + case _ => NodeSeq.Empty + }) + case _ => None } } @@ -73,7 +75,7 @@ class PatternMatchingTest { Blabla Blubabla Baaaaaaalabla - ; + assertTrue(NodeSeq.fromSeq(books.child) match { case t @ Seq(Blabla) => false diff --git a/shared/src/test/scala/scala/xml/ShouldCompile.scala b/shared/src/test/scala/scala/xml/ShouldCompile.scala index 0059a0b83..e394b4b90 100644 --- a/shared/src/test/scala/scala/xml/ShouldCompile.scala +++ b/shared/src/test/scala/scala/xml/ShouldCompile.scala @@ -64,7 +64,7 @@ object SI_5858 { class Floozy { def fooz(x: Node => String) = {} def foo(m: Node): Unit = fooz { - case Elem(_, _, _, _, n, _*) if (n == m) => "gaga" + case Elem(_, _, _, _, n, _*) if n == m => "gaga" } } diff --git a/shared/src/test/scala/scala/xml/UtilityTest.scala b/shared/src/test/scala/scala/xml/UtilityTest.scala index de4a8c29e..73d4a85a4 100644 --- a/shared/src/test/scala/scala/xml/UtilityTest.scala +++ b/shared/src/test/scala/scala/xml/UtilityTest.scala @@ -83,7 +83,7 @@ class UtilityTest { @Test def escapePrintablesTest: Unit = { for { - char <- (printableAscii.diff(escapedChars)) + char <- printableAscii.diff(escapedChars) } yield { assertEquals(char.toString, Utility.escape(char.toString)) } @@ -120,7 +120,7 @@ class UtilityTest { @Test def escapeUnicodeExtendedControlCodesTest: Unit = { for { - char <- ('\u0080' to '\u009f') // Extended control codes (C1) + char <- '\u0080' to '\u009f' // Extended control codes (C1) } yield { assertEquals(char.toString, Utility.escape(char.toString)) } @@ -129,7 +129,7 @@ class UtilityTest { @Test def escapeUnicodeTwoBytesTest: Unit = { for { - char <- ('\u00A0' to '\u07FF') // Two bytes (cont.) + char <- '\u00A0' to '\u07FF' // Two bytes (cont.) } yield { assertEquals(char.toString, Utility.escape(char.toString)) } @@ -138,7 +138,7 @@ class UtilityTest { @Test def escapeUnicodeThreeBytesTest: Unit = { for { - char <- ('\u0800' to '\uFFFF') // Three bytes + char <- '\u0800' to '\uFFFF' // Three bytes } yield { assertEquals(char.toString, Utility.escape(char.toString)) } @@ -193,7 +193,7 @@ class UtilityTest { '\u001E' -> "^^", // Record separator '\u001F' -> "^_", // Unit separator '\u007F' -> "^?" // Delete - ).toMap.withDefault { + ).withDefault { (key: Char) => key.toString } diff --git a/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala b/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala index 26410a9af..700709f29 100644 --- a/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala +++ b/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala @@ -55,11 +55,11 @@ class XMLSyntaxTest { @Test def test2(): Unit = { val x1: Option[Seq[Node]] = Some(hello) - val n1 = ; + val n1 = assertEquals(x1, n1.attribute("key")) val x2: Option[Seq[Node]] = None - val n2 = ; + val n2 = assertEquals(x2, n2.attribute("key")) } diff --git a/shared/src/test/scala/scala/xml/XMLTest.scala b/shared/src/test/scala/scala/xml/XMLTest.scala index 8e8e3acb0..f57aeb2fa 100644 --- a/shared/src/test/scala/scala/xml/XMLTest.scala +++ b/shared/src/test/scala/scala/xml/XMLTest.scala @@ -28,9 +28,9 @@ class XMLTest { val pelems_1 = for (x <- p \ "bar"; y <- p \ "baz") yield { Text(x.attributes("value").toString + y.attributes("bazValue").toString + "!") - }; + } - val pelems_2 = NodeSeq.fromSeq(List(Text("38!"), Text("58!"))); + val pelems_2 = NodeSeq.fromSeq(List(Text("38!"), Text("58!"))) assertTrue(pelems_1 sameElements pelems_2) assertTrue(Text("8") sameElements (p \\ "@bazValue")) } @@ -42,7 +42,7 @@ class XMLTest { Blabla Blubabla Baaaaaaalabla - ; + val reviews = @@ -64,16 +64,16 @@ class XMLTest { rem 2 - ; + val results1 = new scala.xml.PrettyPrinter(80, 5).formatNodes( - for ( - t <- books \\ "title"; + for { + t <- books \\ "title" r <- reviews \\ "entry" if (r \ "title") xml_== t - ) yield + } yield { t } { r \ "remarks" } - ); + ) val results1Expected = """ | Blabla | Hallo Welt. @@ -110,7 +110,7 @@ class XMLTest { +41 21 693 68 67 +41 79 602 23 23 - ; + val addrBook = @@ -125,13 +125,13 @@ class XMLTest { Elm Street Dolphin City - ; + val actual: String = new scala.xml.PrettyPrinter(80, 5).formatNodes( - for ( - t <- addrBook \\ "entry"; + for { + t <- addrBook \\ "entry" r <- phoneBook \\ "entry" if (t \ "name") xml_== (r \ "name") - ) yield + } yield { t.child } { r \ "phone" } ) @@ -160,7 +160,7 @@ class XMLTest { val cuckoo = - ; + assertEquals("http://cuckoo.com", cuckoo.namespace) for (n <- cuckoo \ "_") { assertEquals("http://cuckoo.com", n.namespace) @@ -197,7 +197,7 @@ class XMLTest { @UnitTest def dodgyNamespace = { val x = - assertTrue(x.toString.matches(".*xmlns:dog=\"http://dog.com\".*")); + assertTrue(x.toString.matches(".*xmlns:dog=\"http://dog.com\".*")) } val ax = @@ -302,15 +302,15 @@ Ours is the portal of hope, come as you are." // t-486 def wsdlTemplate1(serviceName: String): Node = - ; + def wsdlTemplate2(serviceName: String, targetNamespace: String): Node = - ; + def wsdlTemplate4(serviceName: String, targetNamespace: () => String): Node = - ; + @UnitTest def wsdl = {