Restore behaviour avoiding incorrect warnings

EugeneFlesselle · EugeneFlesselle · commit 0b8e1024f94c · 2024-08-06T22:56:56.000+02:00
Specifically, in cases where we could report a change in prioritization,
despite having not done `tryImplicit` on the alternative,
i.e. it was only compared as part of an early filtering
diff --git a/compiler/src/dotty/tools/dotc/typer/Implicits.scala b/compiler/src/dotty/tools/dotc/typer/Implicits.scala
@@ -1492,8 +1492,8 @@ trait Implicits:
                     // need a candidate better than the two ambiguous alternatives.
                     val ambi = fail.reason.asInstanceOf[AmbiguousImplicits]
                     healAmbiguous(fail, newCand =>
-                      compareAlternatives(newCand, ambi.alt1, disambiguate = true) > 0 &&
-                      compareAlternatives(newCand, ambi.alt2, disambiguate = true) > 0)
+                      compareAlternatives(newCand, ambi.alt1) > 0 &&
+                      compareAlternatives(newCand, ambi.alt2) > 0)
                 }
             }
           case nil =>

Original file line number	Diff line number	Diff line change
`@@ -1492,8 +1492,8 @@ trait Implicits:`
`1492`	`1492`	`// need a candidate better than the two ambiguous alternatives.`
`1493`	`1493`	`val ambi = fail.reason.asInstanceOf[AmbiguousImplicits]`
`1494`	`1494`	`healAmbiguous(fail, newCand =>`
`1495`		`- compareAlternatives(newCand, ambi.alt1, disambiguate = true) > 0 &&`
`1496`		`- compareAlternatives(newCand, ambi.alt2, disambiguate = true) > 0)`
	`1495`	`+ compareAlternatives(newCand, ambi.alt1) > 0 &&`
	`1496`	`+ compareAlternatives(newCand, ambi.alt2) > 0)`
`1497`	`1497`	`}`
`1498`	`1498`	`}`
`1499`	`1499`	`case nil =>`